-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy protocol contracts on new chains #1562
Conversation
@Ashar2shahid the E2E test failure will be resolved once you update this branch to the latest master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions
@@ -9,6 +9,7 @@ | |||
"sepolia": "", | |||
"arbitrumOne": "<arbitrum>", | |||
"arbitrumTestnet": "<arbitrum-testnet>", | |||
"aurora": "<aurora>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is added but I'm seeing that the contracts are not verified on https://aurorascan.dev/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hardhat does support aurora but when I try to run the verify command I get the following error:
airnode-protocol/deploy/2_verify.js:
: ENOENT: no such file or directory, open '/home/ashar/API3/airnode/packages/airnode-protocol/artifacts/build-info/37ae4407f650f87f7cba868b566e365f.json'
at DeploymentsManager.executeDeployScripts (/home/ashar/API3/airnode/node_modules/hardhat-deploy/src/DeploymentsManager.ts:1222:19)
at DeploymentsManager.runDeploy (/home/ashar/API3/airnode/node_modules/hardhat-deploy/src/DeploymentsManager.ts:1052:5)
at SimpleTaskDefinition.action (/home/ashar/API3/airnode/node_modules/hardhat-deploy/src/index.ts:438:5)
at Environment._runTaskDefinition (/home/ashar/API3/airnode/node_modules/hardhat/src/internal/core/runtime-environment.ts:219:14)
at Environment.run (/home/ashar/API3/airnode/node_modules/hardhat/src/internal/core/runtime-environment.ts:131:14)
at SimpleTaskDefinition.action (/home/ashar/API3/airnode/node_modules/hardhat-deploy/src/index.ts:584:32)
at Environment._runTaskDefinition (/home/ashar/API3/airnode/node_modules/hardhat/src/internal/core/runtime-environment.ts:219:14)
at Environment.run (/home/ashar/API3/airnode/node_modules/hardhat/src/internal/core/runtime-environment.ts:131:14)
at SimpleTaskDefinition.action (/home/ashar/API3/airnode/node_modules/hardhat-deploy/src/index.ts:669:5)
at Environment._runTaskDefinition (/home/ashar/API3/airnode/node_modules/hardhat/src/internal/core/runtime-environment.ts:219:14)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.Error:: command not found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The contracts do get verified locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had all previous deployments verified on the etherscan/blockscout block explorers manually. You can find the flattened versions at ftmscan.com or flatten them yourself using hardhat flatten
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed for decoding of transactions and in the etherscan case to allow the user interact with the contract over etherscan, it's not necessarily about verification that the contract is correct (that's what deterministic deployments and verify-local
are for).
Added
|
All Contracts are getting verified locally @bbenligiray this should be good for review |
This is actively on my to do list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aurora-testnet
contracts are not verified on https://testnet.aurorascan.dev/
aurora
contracts are verified on https://aurorascan.dev/ but Aurora is migrating to https://explorer.mainnet.aurora.dev/ on Feb 1 https://twitter.com/auroraisnear/status/1610297709272899584 They don't seem to have Blockscout set up for the testnet so we'll have to skip that.
Rest of the deployments except boba-ethereum
and AccessControlRegistry on godwoken
are not verified. Verify everything you can and document the remaining ones in a Github issue to be done later.
arbitrum-nova aurora aurora-testnet
I tried sending transactions to the functions a few days ago but etherscan still doesn't see it as a contract boba-avalanche boba-bnb boba-moonbeam godwoken godwoken-testnet sx-network sx-network-testnet |
Created issue for verifying contracts on block explorers: #1630 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the issue and 👍 for the sx-network-testnet redeployment
Closes #1626
This PR deploys the protocol contracts on the following chains:
Used deterministic deployment whenever possible