Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of quotation marks in secrets #1513

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Fix handling of quotation marks in secrets #1513

merged 1 commit into from
Oct 28, 2022

Conversation

amarthadan
Copy link
Contributor

Fix #1510

@amarthadan amarthadan requested a review from a team October 27, 2022 13:33
@amarthadan amarthadan self-assigned this Oct 27, 2022
Siegrift
Siegrift approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, but I haven't tested e2e.

@dcroote
Copy link
Contributor

dcroote commented Oct 27, 2022

Is there any fix required for the airnode client?

@amarthadan
Copy link
Contributor Author

Is there any fix required for the airnode client?

Good question. Secrets there are loaded via dotenv that handles quotes correctly (I've just tested it) 🙂

@dcroote
Copy link
Contributor

dcroote commented Oct 28, 2022

Good question. Secrets there are loaded via dotenv that handles quotes correctly (I've just tested it) 🙂

Nice!

@amarthadan amarthadan merged commit 3a69963 into master Oct 28, 2022
@amarthadan amarthadan deleted the fix-quoted-secrets branch October 28, 2022 05:35
@amarthadan amarthadan mentioned this pull request Oct 28, 2022
Merged
@martinkolenic
Copy link
Contributor

Test: Check if quotation marks in secrets cause deployment errors
Versions tested: v0.9.1 snapshots; master
Deployed to: AWS
Testnet: Görli

Test flow: Create secrets.env and wrap secret values in quotation marks, then attempt deployment
Subtests: Only wrap one of the values in quotes, vary the values quoted

Expected results: Quotation marks are ignored, deployment successful and Airnode works, fulfilling API requests.
Actual results: Matches expected results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siegrift Siegrift Siegrift approved these changes

Assignees

@amarthadan amarthadan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Airnode fails at runtime if secrets are quoted
4 participants
@amarthadan @dcroote @martinkolenic @Siegrift