Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Airnode fails at runtime if secrets are quoted #1510

Closed
Siegrift opened this issue Oct 27, 2022 · 3 comments · Fixed by #1513
Closed

Airnode fails at runtime if secrets are quoted #1510

Siegrift opened this issue Oct 27, 2022 · 3 comments · Fixed by #1513
Assignees
@martinkolenic
Milestone
0.10.0

Comments

@Siegrift
Copy link
Contributor

Siegrift commented Oct 27, 2022 •
edited
Loading

Raised internally in https://api3workspace.slack.com/archives/C02R79STBRA/p1666803628395139
@Siegrift Siegrift changed the title Airnode runtime failure if secrets are quoted Airnode fails at runtime if secrets are quoted Oct 27, 2022
@amarthadan amarthadan self-assigned this Oct 27, 2022
@amarthadan amarthadan added this to the 0.10.0 milestone Oct 27, 2022
@amarthadan amarthadan mentioned this issue Oct 27, 2022
Merged
@andreogle
Copy link
Member

Made this comment on the PR, but I think the issue is more appropriate so moving it here:

Is the plan to release a v0.9.1 for this fix? Does this affect any other prior versions?

@amarthadan
Copy link
Contributor

Is the plan to release a v0.9.1 for this fix?

Yes, it just slipped my mind, thanks for reminding me 🙂

Does this affect any other prior versions?

It does not. I've introduced the bug in this commit b67047b and it's only part of the v0.9.

@martinkolenic
Copy link
Contributor

Test: Check if quotation marks in secrets cause deployment errors
Versions tested: v0.9.1 snapshots; master
Deployed to: AWS
Testnet: Görli

Test flow: Create secrets.env and wrap secret values in quotation marks, then attempt deployment
Subtests: Only wrap one of the values in quotes, vary the values quoted

Expected results: Quotation marks are ignored, deployment successful and Airnode works, fulfilling API requests.
Actual results: Matches expected results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinkolenic martinkolenic

Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

Fix handling of quotation marks in secrets api3dao/airnode
4 participants
@martinkolenic @amarthadan @andreogle @Siegrift