Fix denominator in output stats to all mapped reads only, not all in BAM #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TCLamnidis and I realised recently that DeDup incorrectly reports dedupping stats when unmapped reads are included in the BAM file. In EAGER1, unmapped reads were removed by default, but eager2 has a different behaviour.
By leaving in unmapped reads, and using 'totals reads' in the BAM file, this makes an artificially large denominator that makes cluster factors/duplication rates much smaller than they actually are.
As de-dupping is performed on coordinates on the reference genome, dedupping only effects mapped reads therefore all stats should be based on that value.