Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeDup stats reporting is incorrect when unmapped reads included (the default in EAGER) #560

Closed
jfy133 opened this issue Sep 24, 2020 · 2 comments · Fixed by #565
Closed

DeDup stats reporting is incorrect when unmapped reads included (the default in EAGER) #560

jfy133 opened this issue Sep 24, 2020 · 2 comments · Fixed by #565
Labels
bug Something isn't working pending Addressed on branch waiting for related PR
Milestone
2.2 "Ulm"

Comments

@jfy133
Copy link
Member

jfy133 commented Sep 24, 2020

See apeltzer/DeDup#10
@jfy133 jfy133 added bug Something isn't working needs upstream fix Needs a fix in the upstream tool project labels Sep 24, 2020
@jfy133 jfy133 added this to the V2.2 "Ulm" milestone Sep 24, 2020
@jfy133
Copy link
Member Author

jfy133 commented Sep 25, 2020

Possible fix: apeltzer/DeDup#11

@apeltzer
Copy link
Member

Upstream fixed, should bump DeDup on Bioconda, then this is also fixed here.

@jfy133 jfy133 mentioned this issue Sep 28, 2020
Merged
8 tasks
@jfy133 jfy133 added pending Addressed on branch waiting for related PR and removed needs upstream fix Needs a fix in the upstream tool project labels Oct 1, 2020
@jfy133 jfy133 closed this as completed Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working pending Addressed on branch waiting for related PR
Projects
None yet
Milestone
2.2 "Ulm"
Development

Successfully merging a pull request may close this issue.

Bump DeDup for stats fix and DamageProfiler to latest version nf-core/eager
2 participants
@apeltzer @jfy133