ZOOKEEPER-3008: Potential NPE in SaslQuorumAuthLearner#authenticate and SaslQuorumAuthServer#authenticate

src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java

@@ -94,7 +94,11 @@ public void authenticate(Socket sock, String hostName) throws IOException {
                     principalConfig,
                     QuorumAuth.QUORUM_SERVER_PROTOCOL_NAME,
                     QuorumAuth.QUORUM_SERVER_SASL_DIGEST, LOG, "QuorumLearner");
-
+            // may happen NPE at here
+            if (sc == null) {
+                LOG.error("SaslClient object is null while trying to create SASL client");
+                throw new RuntimeException("Exception while trying to create SASL client");
+            }
             if (sc.hasInitialResponse()) {
                 responseToken = createSaslToken(new byte[0], sc, learnerLogin);
             }
@@ -134,6 +138,8 @@ public void authenticate(Socket sock, String hostName) throws IOException {
 
             // Validate status code at the end of authentication exchange.
             checkAuthStatus(sock, qpStatus);
+        } catch (RuntimeException e) {
+            // do nothing
         } finally {
             if (sc != null) {
                 try {

src/java/main/org/apache/zookeeper/util/SecurityUtils.java

@@ -135,6 +135,7 @@ public SaslClient run() throws SaslException {
                 return saslClient;
             } catch (Exception e) {
                 LOG.error("Exception while trying to create SASL client", e);
+                // may cause NPE at the caller
                 return null;
             }
         }