fix typo: resourse -> resource #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Hiroki, Thank you for the patch. Could you create a new JIRA for this and submit a patch following the instructions on the HowToContribute page? https://issues.apache.org/jira/browse/ZOOKEEPER Thanks! |
zhaxiancheng
pushed a commit
to zhaxiancheng/zookeeper
that referenced
this pull request
Sep 8, 2016
-Pass keyCount to runScript method
zhaxiancheng
pushed a commit
to zhaxiancheng/zookeeper
that referenced
this pull request
Sep 8, 2016
trSsl tls support with tests
ztzg
pushed a commit
to ztzg/zookeeper
that referenced
this pull request
Aug 12, 2019
…apache#1 This first patch implements the zookeeper sasl operations, extends the zkServer.sh test script with the ability to start a sasl enabled server and adds a test that checks the initial DIGEST-MD5 response. It introduces no external requirements but provides zoo_sasl/zoo_asasl functions that allow applications (or the addon from patch apache#2) to communicate with the sasl server backend. Patch apache#2 will add a simple api for sasl authentication, patch apache#3 includes a sasl enabled command line client. (Forward-ported from https://reviews.apache.org/r/2252/ by Damien Diederen.)
ztzg
pushed a commit
to ztzg/zookeeper
that referenced
this pull request
Aug 12, 2019
…apache#3 3rd patch * includes a sasl-enabled cli as additional make artifacts When using the test configuration as in tests/jaas.digest.server.conf you can login via: cli_sasl_st -u super -h zk-sasl-md5 -m DIGEST-MD5 hostlist and password 'test'. If you set up Kerberos 5 on the server side and have a valid ticket its just: cli_sasl_st -m GSSAPI hostlist (Forward-ported from ticket attachment ZOOKEEPER-1112_3.patch by Damien Diederen.)
ztzg
pushed a commit
to ztzg/zookeeper
that referenced
this pull request
Aug 14, 2019
…apache#3 3rd patch * includes a sasl-enabled cli as additional make artifacts When using the test configuration as in tests/jaas.digest.server.conf you can login via: cli_sasl_st -u super -h zk-sasl-md5 -m DIGEST-MD5 hostlist and password 'test'. If you set up Kerberos 5 on the server side and have a valid ticket its just: cli_sasl_st -m GSSAPI hostlist (Forward-ported from ticket attachment ZOOKEEPER-1112_3.patch by Damien Diederen.)
ztzg
pushed a commit
to ztzg/zookeeper
that referenced
this pull request
Aug 21, 2019
…apache#3 3rd patch * includes a sasl-enabled cli as additional make artifacts When using the test configuration as in tests/jaas.digest.server.conf you can login via: cli_sasl_st -u super -h zk-sasl-md5 -m DIGEST-MD5 hostlist and password 'test'. If you set up Kerberos 5 on the server side and have a valid ticket its just: cli_sasl_st -m GSSAPI hostlist (Forward-ported from ticket attachment ZOOKEEPER-1112_3.patch by Damien Diederen.)
ztzg
pushed a commit
to ztzg/zookeeper
that referenced
this pull request
Aug 25, 2019
…apache#1 This first patch implements the zookeeper sasl operations, extends the zkServer.sh test script with the ability to start a sasl enabled server and adds a test that checks the initial DIGEST-MD5 response. It introduces no external requirements but provides zoo_sasl/zoo_asasl functions that allow applications (or the addon from patch apache#2) to communicate with the sasl server backend. Patch apache#2 will add a simple api for sasl authentication, patch apache#3 includes a sasl enabled command line client. (Forward-ported from https://reviews.apache.org/r/2252/ by Damien Diederen.)
ztzg
pushed a commit
to ztzg/zookeeper
that referenced
this pull request
Aug 25, 2019
…apache#3 3rd patch * includes a sasl-enabled cli as additional make artifacts When using the test configuration as in tests/jaas.digest.server.conf you can login via: cli_sasl_st -u super -h zk-sasl-md5 -m DIGEST-MD5 hostlist and password 'test'. If you set up Kerberos 5 on the server side and have a valid ticket its just: cli_sasl_st -m GSSAPI hostlist (Forward-ported from ticket attachment ZOOKEEPER-1112_3.patch by Damien Diederen.)
ztzg
pushed a commit
to ztzg/zookeeper
that referenced
this pull request
Sep 19, 2019
…apache#1 This first patch implements the zookeeper sasl operations, extends the zkServer.sh test script with the ability to start a sasl enabled server and adds a test that checks the initial DIGEST-MD5 response. It introduces no external requirements but provides zoo_sasl/zoo_asasl functions that allow applications (or the addon from patch apache#2) to communicate with the sasl server backend. Patch apache#2 will add a simple api for sasl authentication, patch apache#3 includes a sasl enabled command line client. (Forward-ported from https://reviews.apache.org/r/2252/ by Damien Diederen.)
ztzg
pushed a commit
to ztzg/zookeeper
that referenced
this pull request
Sep 19, 2019
…apache#3 3rd patch * includes a sasl-enabled cli as additional make artifacts When using the test configuration as in tests/jaas.digest.server.conf you can login via: cli_sasl_st -u super -h zk-sasl-md5 -m DIGEST-MD5 hostlist and password 'test'. If you set up Kerberos 5 on the server side and have a valid ticket its just: cli_sasl_st -m GSSAPI hostlist (Forward-ported from ticket attachment ZOOKEEPER-1112_3.patch by Damien Diederen.)
ztzg
pushed a commit
to ztzg/zookeeper
that referenced
this pull request
Nov 20, 2019
supporting reconnecting to ZK server when disconnected.
anmolnar
added a commit
to anmolnar/zookeeper
that referenced
this pull request
Jul 24, 2020
This was referenced Mar 6, 2021
asfgit
pushed a commit
that referenced
this pull request
Mar 9, 2021
`InvalidSnapshotTest.testSnapshot` starts an instance of `ZooKeeperServer` on the version-controlled `resources/data/invalidsnap` directory, which, as a side-effect, \"fixes\" the following snapshot—which was broken on purpose (see ZOOKEEPER-367): `zookeeper-server/src/test/resources/data/invalidsnap/version-2/snapshot.83f` This status quo creates a number of problems: 1. It makes the test ineffective after the first run; 2. The file shows as modified in version control tools, which can be annoying; 3. The \"fixed\" snapshot can end up being committed by mistake, invalidating the test. (\#3 is not theoretical; that \"fixed\" snapshot frequently shows up in pull requests, and was recently merged into `master`.) Author: Damien Diederen <[email protected]> Reviewers: Mohammad Arshad <[email protected]> Closes #1628 from ztzg/ZOOKEEPER-4232-invalid-snapshot-is-invalid-x-3.6 and squashes the following commits: 508d6a3 [Damien Diederen] ZOOKEEPER-4232: Ensure that ZOOKEEPER-367 test data fails to parse a8ce9e5 [Damien Diederen] ZOOKEEPER-4232: Run InvalidSnapshotTest on a copy of test data
asfgit
pushed a commit
that referenced
this pull request
Mar 9, 2021
`InvalidSnapshotTest.testSnapshot` starts an instance of `ZooKeeperServer` on the version-controlled `resources/data/invalidsnap` directory, which, as a side-effect, \"fixes\" the following snapshot—which was broken on purpose (see ZOOKEEPER-367): `zookeeper-server/src/test/resources/data/invalidsnap/version-2/snapshot.83f` This status quo creates a number of problems: 1. It makes the test ineffective after the first run; 2. The file shows as modified in version control tools, which can be annoying; 3. The \"fixed\" snapshot can end up being committed by mistake, invalidating the test. (\#3 is not theoretical; that \"fixed\" snapshot frequently shows up in pull requests, and was recently merged into `master`.) Author: Damien Diederen <[email protected]> Reviewers: Mohammad Arshad <[email protected]> Closes #1629 from ztzg/ZOOKEEPER-4232-invalid-snapshot-is-invalid-x-3.5 and squashes the following commits: 5286405 [Damien Diederen] ZOOKEEPER-4232: Ensure that ZOOKEEPER-367 test data fails to parse 680c57a [Damien Diederen] ZOOKEEPER-4232: Run InvalidSnapshotTest on a copy of test data
asfgit
pushed a commit
that referenced
this pull request
Mar 9, 2021
`InvalidSnapshotTest.testSnapshot` starts an instance of `ZooKeeperServer` on the version-controlled `resources/data/invalidsnap` directory, which, as a side-effect, \"fixes\" the following snapshot—which was broken on purpose (see ZOOKEEPER-367): `zookeeper-server/src/test/resources/data/invalidsnap/version-2/snapshot.83f` This status quo creates a number of problems: 1. It makes the test ineffective after the first run; 2. The file shows as modified in version control tools, which can be annoying; 3. The \"fixed\" snapshot can end up being committed by mistake, invalidating the test. (\#3 is not theoretical; that \"fixed\" snapshot frequently shows up in pull requests, and was recently merged into `master`.) Author: Damien Diederen <[email protected]> Reviewers: Mohammad Arshad <[email protected]> Closes #1627 from ztzg/ZOOKEEPER-4232-invalid-snapshot-is-invalid-x-3.7 and squashes the following commits: c18a895 [Damien Diederen] ZOOKEEPER-4232: Ensure that ZOOKEEPER-367 test data fails to parse 42a5a0b [Damien Diederen] ZOOKEEPER-4232: Run InvalidSnapshotTest on a copy of test data
asfgit
pushed a commit
that referenced
this pull request
Mar 9, 2021
`InvalidSnapshotTest.testSnapshot` starts an instance of `ZooKeeperServer` on the version-controlled `resources/data/invalidsnap` directory, which, as a side-effect, \"fixes\" the following snapshot—which was broken on purpose (see ZOOKEEPER-367): `zookeeper-server/src/test/resources/data/invalidsnap/version-2/snapshot.83f` This status quo creates a number of problems: 1. It makes the test ineffective after the first run; 2. The file shows as modified in version control tools, which can be annoying; 3. The \"fixed\" snapshot can end up being committed by mistake, invalidating the test. (\#3 is not theoretical; that \"fixed\" snapshot frequently shows up in pull requests, and was recently merged into `master`.) Author: Damien Diederen <[email protected]> Reviewers: Mohammad Arshad <[email protected]> Closes #1627 from ztzg/ZOOKEEPER-4232-invalid-snapshot-is-invalid-x-3.7 and squashes the following commits: c18a895 [Damien Diederen] ZOOKEEPER-4232: Ensure that ZOOKEEPER-367 test data fails to parse 42a5a0b [Damien Diederen] ZOOKEEPER-4232: Run InvalidSnapshotTest on a copy of test data (cherry picked from commit 4a19dd1) Signed-off-by: Mohammad Arshad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to be a trivial typo. Isn't it?