WIP: [ZEPPELIN-2881] Fix OIDC logout #2552
Conversation
| // force authcBasic (if configured) to logout | ||
| $http.post(logoutURL).error(function () { | ||
|
|
||
| let config = (process.env.PROD) ? {headers: { 'X-Requested-With': 'XMLHttpRequest' }} : {} |
There was a problem hiding this comment.
I kept this since this: #2463
| let config = (process.env.PROD) ? {headers: { 'X-Requested-With': 'XMLHttpRequest' }} : {} | ||
| $http.post(logoutURL, config).then( | ||
| function (response) { | ||
| alert('ok response status ', response.status) |
There was a problem hiding this comment.
I'm not sure we should have a blocking dialog box here?
There was a problem hiding this comment.
I can remove it of course, this was simply the original behavior... just tell me what to do :-)
There was a problem hiding this comment.
argh sorry, haven't noticed
There was a problem hiding this comment.
removed, you were correct, thanks!
|
I don't see the alert in the original code? Could you point me to it?
|
|
yes, the original code I think is the result of a few iterations. But you can also notice that a double post is performed without meaningful comments to justify why...
I think that someone like @1ambda or @Leemoonsoo maybe can clarify and add it's opinion to decide if keep the pop-up or not (personally I do not care ...) |
|
sorry @felixcheung misunderstood your comment, should be fixed now! |
|
hi - sorry about the delay, it looks like Jenkins can't locate the test results - could you close/reopen this PR to kick off another test run? |
|
also please update the title to remove WIP if you are ready |
|
Hi thanks for getting back into this, unfortunately even if pac4j/pac4j#975 got merged we do not have yet a release of pac4j out in public repositories that will enable this fix. |
|
Hmm sounds like we need to wait.
|
|
Is waiting now over? |
|
waiting is over but |
|
Hi, I've made an integration of the oidc logout and have included a new profile (oidc) in order to build zeppelin with oidc related libs. I've started my work on branch-0.8 because master doesn't build with scala 2.11 at the moment. Would you like me to push my PR in this issue or do I have to create a new issue and ask if I can add a new profile for oidc ? I think it would be better to create a new one. |
|
@andreaTP with the configuration above what should be printed as username after login? I only get sth like an id. |
Got it. One can set in shiro.ini and it sets the email as displayed login name. |
|
Hello, |
What is this PR for?
Fixing logout mechanism for OIDC.
Initial documentation for configuring OIDC in Zeppelin.
What type of PR is it?
[Bug Fix & Improvement]
Todos
What is the Jira issue?
[ZEPPELIN-2881]
How should this be tested?
You can test by using the guide provided in documentation. Please note that you will need to locally deploy pac4j until a stable release will be published officially.