Fix zeppelin-web development mode #2463
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested (dev mode), works fine, LGTM |
|
Few days I too was thinking about this, thanks for the fix. LGTM. |
|
Tested locally, LGTM. |
|
Tested and LGTM |
|
Thanks @tinkoff-dwh @prabhjyotsingh @1ambda @soralee for review. Merge to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
After #2373, zeppelin-web dev mode does not work properly.
Dev mode always ask user login (even if authentication is turned off) and any login attempt will fail. So it makes difficult to develop front-end.
This PR fixes problem by not adding
X-Requested-With: XMLHttpRequestheader in dev mode.What type of PR is it?
Bug Fix
Todos
How should this be tested?
run zeppelin-web dev mode and see if you can login / open notebook
Questions: