[MKL] Fix offloading of batch_matmul to MKL #6752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comaniac
approved these changes
Oct 25, 2020
|
Thanks @comaniac |
zhiics
pushed a commit
to zhiics/tvm
that referenced
this pull request
Oct 28, 2020
* fix mkl offloading of batch matmul * name fix and add doc * add doc for lib arg Co-authored-by: masa <[email protected]>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Oct 29, 2020
* fix mkl offloading of batch matmul * name fix and add doc * add doc for lib arg Co-authored-by: masa <[email protected]>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 2, 2020
* fix mkl offloading of batch matmul * name fix and add doc * add doc for lib arg Co-authored-by: masa <[email protected]>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 4, 2020
* fix mkl offloading of batch matmul * name fix and add doc * add doc for lib arg Co-authored-by: masa <[email protected]>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 4, 2020
* fix mkl offloading of batch matmul * name fix and add doc * add doc for lib arg Co-authored-by: masa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6182, a new extern lib
mklwas added to separate MKL offload from cblas. But x86 batch_matmul schedule was not updated to reflect that change, so adding-libs=mklwon't call mkl batched matmul. (I think before #6182,-libs=cblaswill call mkl batch matmul if mkl is enabled)please review @tkonolige @icemelon9 @anijain2305 @tqchen