[Topi,x86] Split MKL from BLAS. #6182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkonolige
force-pushed
the
multiblas
branch
2 times, most recently
from
26e722f to
5e9583d
Compare
Make cblas and mkl seperate entities in cmake and topi, allowing users to use both a BLAS library and MKL. In the future, MKL specific functions can be added easily. MKLDNN is also split off from MKL and BLAS for the same reasons. Other improvements: - cblas and mkl strategies are now only applied when they are viable. - compile_engine will log which implementation it has chosen and why.
|
I can understand separating MKLDNN from the BLAS. But why separate the MKL from BLAS library? |
|
Separating MKL from BLAS has two purposes: 1. We can compare other BLAS implementations vs MKL. I think MKL can be better in general, but we have no way of comparing. 2. MKL has a number of operations that are not part of BLAS like batch matrix products and sparse matrix products. With MKL separate, it is easier to add these features. |
|
@icemelon9 please follow up :) |
tqchen
approved these changes
Aug 11, 2020
|
Thanks @tkonolige @icemelon9 ! |
wjliu1998
pushed a commit
to wjliu1998/incubator-tvm
that referenced
this pull request
Aug 13, 2020
Make cblas and mkl seperate entities in cmake and topi, allowing users to use both a BLAS library and MKL. In the future, MKL specific functions can be added easily. MKLDNN is also split off from MKL and BLAS for the same reasons. Other improvements: - cblas and mkl strategies are now only applied when they are viable. - compile_engine will log which implementation it has chosen and why.
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
Make cblas and mkl seperate entities in cmake and topi, allowing users to use both a BLAS library and MKL. In the future, MKL specific functions can be added easily. MKLDNN is also split off from MKL and BLAS for the same reasons. Other improvements: - cblas and mkl strategies are now only applied when they are viable. - compile_engine will log which implementation it has chosen and why.
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
Make cblas and mkl seperate entities in cmake and topi, allowing users to use both a BLAS library and MKL. In the future, MKL specific functions can be added easily. MKLDNN is also split off from MKL and BLAS for the same reasons. Other improvements: - cblas and mkl strategies are now only applied when they are viable. - compile_engine will log which implementation it has chosen and why.
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
Make cblas and mkl seperate entities in cmake and topi, allowing users to use both a BLAS library and MKL. In the future, MKL specific functions can be added easily. MKLDNN is also split off from MKL and BLAS for the same reasons. Other improvements: - cblas and mkl strategies are now only applied when they are viable. - compile_engine will log which implementation it has chosen and why.
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Sep 2, 2020
Make cblas and mkl seperate entities in cmake and topi, allowing users to use both a BLAS library and MKL. In the future, MKL specific functions can be added easily. MKLDNN is also split off from MKL and BLAS for the same reasons. Other improvements: - cblas and mkl strategies are now only applied when they are viable. - compile_engine will log which implementation it has chosen and why.
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 3, 2020
Make cblas and mkl seperate entities in cmake and topi, allowing users to use both a BLAS library and MKL. In the future, MKL specific functions can be added easily. MKLDNN is also split off from MKL and BLAS for the same reasons. Other improvements: - cblas and mkl strategies are now only applied when they are viable. - compile_engine will log which implementation it has chosen and why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make cblas and mkl seperate entities in cmake and topi, allowing users
to use both a BLAS library and MKL. In the future, MKL specific
functions can be added easily. MKLDNN is also split off from MKL and
BLAS for the same reasons.
Other improvements:
@merrymercy @icemelon9