[BYOC][ETHOSN] Add support for quantized convolution #6335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds support for quantized convolution. This includes mapping it via a composite function and all the necessary methods to convert from Relay to the APIs in Support Library. Co-authored-by: Leo Blonk <[email protected]> Co-authored-by: Tristan O'Connor <[email protected]>
Change-Id: I0794b0ac6190478e2d1b858ad0dd90f37fc0207b
Change-Id: Iab865619b449a3d0dd6bb0dbdcb198acd529fc4e
comaniac
requested changes
Aug 26, 2020
| @@ -50,6 +50,16 @@ bool IsEthosnOp(const Call& call, const std::string& op_name) { | |||
| } | |||
| } | |||
|
|
|||
| bool IsEthosnFunc(const Call& call, const std::string& op_name) { | |||
There was a problem hiding this comment.
It seems to me that this function is not just for checking if a call is for an Ethos-N composite function. Maybe we should move it to a common place, so does IsEthosnOp.
There was a problem hiding this comment.
Do you have a suggestion of a good common location? We could maybe handle this in a follow-up.
There was a problem hiding this comment.
No idea... Let's leave them here for now.
masahi
approved these changes
Aug 26, 2020
Change-Id: I51f90499f7ce82a1ce49f0731d3d50627e1d0225
comaniac
approved these changes
Aug 27, 2020
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 17, 2020
* [BYOC][ETHOSN] Add support for quantized convolution This PR adds support for quantized convolution. This includes mapping it via a composite function and all the necessary methods to convert from Relay to the APIs in Support Library. Co-authored-by: Leo Blonk <[email protected]> Co-authored-by: Tristan O'Connor <[email protected]> * Fix padding change Change-Id: I0794b0ac6190478e2d1b858ad0dd90f37fc0207b * Add docs to Tvm2Npu methods Change-Id: Iab865619b449a3d0dd6bb0dbdcb198acd529fc4e * Remove generate tests Change-Id: I51f90499f7ce82a1ce49f0731d3d50627e1d0225 Co-authored-by: Leo Blonk <[email protected]> Co-authored-by: Tristan O'Connor <[email protected]>
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 18, 2020
* [BYOC][ETHOSN] Add support for quantized convolution This PR adds support for quantized convolution. This includes mapping it via a composite function and all the necessary methods to convert from Relay to the APIs in Support Library. Co-authored-by: Leo Blonk <[email protected]> Co-authored-by: Tristan O'Connor <[email protected]> * Fix padding change Change-Id: I0794b0ac6190478e2d1b858ad0dd90f37fc0207b * Add docs to Tvm2Npu methods Change-Id: Iab865619b449a3d0dd6bb0dbdcb198acd529fc4e * Remove generate tests Change-Id: I51f90499f7ce82a1ce49f0731d3d50627e1d0225 Co-authored-by: Leo Blonk <[email protected]> Co-authored-by: Tristan O'Connor <[email protected]>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 18, 2020
* [BYOC][ETHOSN] Add support for quantized convolution This PR adds support for quantized convolution. This includes mapping it via a composite function and all the necessary methods to convert from Relay to the APIs in Support Library. Co-authored-by: Leo Blonk <[email protected]> Co-authored-by: Tristan O'Connor <[email protected]> * Fix padding change Change-Id: I0794b0ac6190478e2d1b858ad0dd90f37fc0207b * Add docs to Tvm2Npu methods Change-Id: Iab865619b449a3d0dd6bb0dbdcb198acd529fc4e * Remove generate tests Change-Id: I51f90499f7ce82a1ce49f0731d3d50627e1d0225 Co-authored-by: Leo Blonk <[email protected]> Co-authored-by: Tristan O'Connor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for quantized convolution for the Ethos-N backend. This includes mapping it via a composite function and all the necessary methods to convert from Relay to the APIs in Support Library.
Co-authored-by: Leo Blonk [email protected]
Co-authored-by: Tristan O'Connor [email protected]