Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR][PY][API-Change] Polish tvm.runtime, tvm.runtime.module API update #4837

Merged
merged 2 commits into from
Feb 7, 2020

Conversation

tqchen
Copy link
Member

@tqchen tqchen commented Feb 7, 2020

This PR updates the tvm.runtime to use the new FFI style.

  • Remove top-level tvm.module to avoid confusion between runtime.Module and IRModule
  • API changes wrt to runtime.Module
    • tvm.module.load -> tvm.runtime.load_module
    • tvm.module.enabled -> tvm.runtime.enabled
    • tvm.module.system_lib -> tvm.runtime.system_lib
  • Remove dep on api_internal from runtime.

@tqchen
Copy link
Member Author

tqchen commented Feb 7, 2020

cc @FrozenGene @icemelon9 @yzhliu @ZihengJiang

@tqchen tqchen force-pushed the pyrt branch 2 times, most recently from d6f16c6 to 7a01a62 Compare February 7, 2020 01:29
@tqchen tqchen force-pushed the pyrt branch 2 times, most recently from 1d94a6b to 5cf1fd8 Compare February 7, 2020 03:19
@FrozenGene
Copy link
Member

As #4564 is merged, but the doc still use tvm.module.load, would you change to tvm.runtime.load too?

@tqchen
Copy link
Member Author

tqchen commented Feb 7, 2020

@FrozenGene Good catch, i have updated the PR to reflect the lastest set of changes

This PR updates the tvm.runtime to use the new FFI style.

- Remove top-level tvm.module to avoid confusion between runtime.Module and IRModule
- API changes wrt to runtime.Module
  - tvm.module.load -> tvm.runtime.load_module
  - tvm.module.enabled -> tvm.runtime.enabled
  - tvm.module.system_lib -> tvm.runtime.system_lib
- Remove dep on api_internal from runtime.
Copy link
Member

@FrozenGene FrozenGene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

@icemelon icemelon merged commit e0122c0 into apache:master Feb 7, 2020
anijain2305 pushed a commit to anijain2305/tvm that referenced this pull request Feb 10, 2020
… update (apache#4837)

* [REFACTOR][PY-API] Polish tvm.runtime, tvm.runtime.module API update

This PR updates the tvm.runtime to use the new FFI style.

- Remove top-level tvm.module to avoid confusion between runtime.Module and IRModule
- API changes wrt to runtime.Module
  - tvm.module.load -> tvm.runtime.load_module
  - tvm.module.enabled -> tvm.runtime.enabled
  - tvm.module.system_lib -> tvm.runtime.system_lib
- Remove dep on api_internal from runtime.

* Update module.load in the latest API
@kparzysz-quic
Copy link
Contributor

The file jvm/core/src/main/java/org/apache/tvm/Module.java still uses old names. This broke the Java RPC app.

@tqchen
Copy link
Member Author

tqchen commented Feb 12, 2020

@kparzysz-quic Thanks for the catch, here is a patch #4871

alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 26, 2020
… update (apache#4837)

* [REFACTOR][PY-API] Polish tvm.runtime, tvm.runtime.module API update

This PR updates the tvm.runtime to use the new FFI style.

- Remove top-level tvm.module to avoid confusion between runtime.Module and IRModule
- API changes wrt to runtime.Module
  - tvm.module.load -> tvm.runtime.load_module
  - tvm.module.enabled -> tvm.runtime.enabled
  - tvm.module.system_lib -> tvm.runtime.system_lib
- Remove dep on api_internal from runtime.

* Update module.load in the latest API
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 28, 2020
… update (apache#4837)

* [REFACTOR][PY-API] Polish tvm.runtime, tvm.runtime.module API update

This PR updates the tvm.runtime to use the new FFI style.

- Remove top-level tvm.module to avoid confusion between runtime.Module and IRModule
- API changes wrt to runtime.Module
  - tvm.module.load -> tvm.runtime.load_module
  - tvm.module.enabled -> tvm.runtime.enabled
  - tvm.module.system_lib -> tvm.runtime.system_lib
- Remove dep on api_internal from runtime.

* Update module.load in the latest API
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2020
… update (apache#4837)

* [REFACTOR][PY-API] Polish tvm.runtime, tvm.runtime.module API update

This PR updates the tvm.runtime to use the new FFI style.

- Remove top-level tvm.module to avoid confusion between runtime.Module and IRModule
- API changes wrt to runtime.Module
  - tvm.module.load -> tvm.runtime.load_module
  - tvm.module.enabled -> tvm.runtime.enabled
  - tvm.module.system_lib -> tvm.runtime.system_lib
- Remove dep on api_internal from runtime.

* Update module.load in the latest API
tqchen added a commit to tqchen/tvm that referenced this pull request Mar 29, 2020
… update (apache#4837)

* [REFACTOR][PY-API] Polish tvm.runtime, tvm.runtime.module API update

This PR updates the tvm.runtime to use the new FFI style.

- Remove top-level tvm.module to avoid confusion between runtime.Module and IRModule
- API changes wrt to runtime.Module
  - tvm.module.load -> tvm.runtime.load_module
  - tvm.module.enabled -> tvm.runtime.enabled
  - tvm.module.system_lib -> tvm.runtime.system_lib
- Remove dep on api_internal from runtime.

* Update module.load in the latest API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants