Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay][Frontend] TF Tile Round Sign Pow Exp Reverse #2960

Merged
merged 3 commits into from
Apr 19, 2019

Conversation

yongwww
Copy link
Member

@yongwww yongwww commented Apr 4, 2019

Add Tile, ReverseV2, Round, Sign, Pow, Exp in tf converter, most of them are needed for object detection models like ssd.

@srkreddy1238 @kazum @jroesch @zhiics @wweic pls help review

@yongwww
Copy link
Member Author

yongwww commented Apr 4, 2019

pls ignore CI, failed due to "raise RemoteDisconnected" in mxnet test case, not related to my change

@yongwww yongwww changed the title [Relay][Frontend] TF Round Sign Pow Exp Reverse [Relay][Frontend] TF Tile Round Sign Pow Exp Reverse Apr 8, 2019
@yongwww
Copy link
Member Author

yongwww commented Apr 11, 2019

@srkreddy1238 @kazum @jroesch @zhiics @wweic @lixiaoquan ci passed, please help review

Copy link
Contributor

@wweic wweic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks for reordering the operator map, it might be good to mention which operators are newly added.

@yongwww
Copy link
Member Author

yongwww commented Apr 11, 2019

@wweic thanks. The newly added list: Tile, ReverseV2, Round, Sign, Pow, Exp

python/tvm/relay/frontend/tensorflow.py Show resolved Hide resolved
compare_tf_with_tvm([np_data], ['in_data:0'], 'reverse:0')

def test_forward_reverse_v2():
"""test ReverseV2"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a negative axis if supported by TVM.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added, yeah tvm supports this case.

@jroesch jroesch requested a review from srkreddy1238 April 12, 2019 21:35
@tqchen
Copy link
Member

tqchen commented Apr 18, 2019

@srkreddy1238 please followup and manage this PR

@srkreddy1238 srkreddy1238 merged commit 85a3ea0 into apache:master Apr 19, 2019
@srkreddy1238
Copy link
Contributor

Thanks @yongwww . This is now merged.

wweic pushed a commit to wweic/tvm that referenced this pull request May 13, 2019
* [Relay][Frontend] TF Round Sign Pow Exp Reverse

* fix ci

* fix comments
wweic pushed a commit to neo-ai/tvm that referenced this pull request May 13, 2019
* [Relay][Frontend] TF Round Sign Pow Exp Reverse

* fix ci

* fix comments
@yongwww yongwww deleted the neo-ai branch December 8, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants