Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] pydruid export_pandas #9006

Merged
merged 2 commits into from
Jan 23, 2020
Merged

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Jan 23, 2020

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

This PR fixes a regression introduced in #8948 where I mistook that the pydruid export_pandas method alway returned an pd.DataFrame object (I missed the if statement here and thus it could be None.

I noticed another case where we don't check whether the Pandas dataframe exists (see here) but this is outside of the scope of the original PR.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

to: @michellethomas @mistercrunch @villebro

@john-bodley
Copy link
Member Author

@mistercrunch do you know if there are any plans to add typing to pydruid?

@mistercrunch
Copy link
Member

No plans, but I think it depends on deprecating support for py<3.5, which is about time. Happy to review/merge in that direction

@codecov-io
Copy link

Codecov Report

Merging #9006 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9006   +/-   ##
=======================================
  Coverage   59.16%   59.16%           
=======================================
  Files         367      367           
  Lines       11680    11680           
  Branches     2863     2863           
=======================================
  Hits         6910     6910           
  Misses       4591     4591           
  Partials      179      179

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04be1d4...ce848d1. Read the comment docs.

@john-bodley john-bodley merged commit 4b5d141 into master Jan 23, 2020
@john-bodley john-bodley deleted the john-bodley--fix-pydruid-export-pandas branch January 23, 2020 23:38
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants