[fix] Enforce the QueryResult.df to be a pandas.DataFrame (Phase II) #8948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
commented
Jan 11, 2020
| @@ -129,15 +129,14 @@ def get_data( # pylint: disable=invalid-name,no-self-use | |||
| def get_single_payload(self, query_obj: QueryObject) -> Dict[str, Any]: | |||
| """Returns a payload of metadata and data""" | |||
| payload = self.get_df_payload(query_obj) | |||
| df = payload.get("df") | |||
| status = payload.get("status") | |||
| df = payload["df"] | |||
There was a problem hiding this comment.
Note the get is not required as get_df_payload is guaranteed to return a dictionary with the df and status keys per here.
mistercrunch
approved these changes
Jan 12, 2020
12 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Related to #8935 this PR cleans up other places in the code where the
dfvariable was eitherNoneor apandas.DataFrameobject. Given that now bothQueryResultandpydruidguarantee exporting of apandas.DataFrame(which could be empty) the downstream logic is now simplified.TEST PLAN
CI.
ADDITIONAL INFORMATION
REVIEWERS
to: @mistercrunch @michellethomas @villebro @willbarrett