Filter edit icon component replaced with Font Awesome #8600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusackas
changed the title
Codecov Report
@@ Coverage Diff @@
## master #8600 +/- ##
==========================================
- Coverage 65.75% 65.73% -0.03%
==========================================
Files 482 481 -1
Lines 23825 23830 +5
Branches 2594 2593 -1
==========================================
- Hits 15667 15664 -3
- Misses 7985 7993 +8
Partials 173 173
Continue to review full report at Codecov.
|
|
Oh, and for the record, if we do get FAB to upgrade to FontAwesome 5, we can change |
superset/assets/src/dashboard/stylesheets/filter-indicator-tooltip.less
Outdated
Show resolved
Hide resolved
mistercrunch
approved these changes
Nov 20, 2019
dpgaspar
approved these changes
Nov 27, 2019
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
This is pretty minor, but just something I noticed while looking around. Since Superset uses FontAwesome, we can replace a custom component with custom SVG by using a simple FontAwesome image.
We should probably upgrade to FontAwesome 5 at some point... many more toys in that toybox!
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
REVIEWERS
@graceguo-supercat / @mistercrunch
Note: This doesn't change any functionality, but as far as I can tell, that button doesn't have functionality in the first place, or at least nothing happens when I click it. Is it for future use, or am I missing something?