Filter edit icon component replaced with Font Awesome (#8600)

* replaced!

* added role to the FA image/button

* adding tabindex.

* capitalization of tabIndex matters. I'll have another cup of coffee now.

* added newine at end of file, added stylelint rule to track this.

* re-removing these files after merge conflict resolution.

superset/assets/package.json

@@ -227,7 +227,8 @@
   },
   "stylelint": {
     "rules": {
-      "block-opening-brace-space-before": "always"
+      "block-opening-brace-space-before": "always",
+      "no-missing-end-of-source-newline": "never"
     }
   }
 }

superset/assets/src/dashboard/components/FilterIndicatorTooltip.jsx

@@ -21,8 +21,6 @@ import PropTypes from 'prop-types';
 import { t } from '@superset-ui/translation';
 import { isEmpty } from 'lodash';
 
-import FilterEditIcon from '../../components/FilterEditIcon';
-
 const propTypes = {
   label: PropTypes.string.isRequired,
   values: PropTypes.array.isRequired,
@@ -48,7 +46,12 @@ export default function FilterIndicatorTooltip({
       </div>
 
       {clickIconHandler && (
-        <FilterEditIcon clickIconHandler={clickIconHandler} />
+        <i
+          className="fa fa-pencil filter-edit"
+          onClick={clickIconHandler}
+          role="button"
+          tabIndex="0"
+        />
       )}
     </div>
   );

superset/assets/src/dashboard/stylesheets/filter-indicator-tooltip.less

@@ -57,6 +57,7 @@
   }
 
   .filter-edit {
+    cursor: pointer;
     position: absolute;
     top: 4px;
     right: 0;