-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Resizing widgets problem #4596 #4597
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4597 +/- ##
=======================================
Coverage 71.17% 71.17%
=======================================
Files 188 188
Lines 14834 14834
Branches 1086 1086
=======================================
Hits 10558 10558
Misses 4273 4273
Partials 3 3 Continue to review full report at Codecov.
|
@@ -89,7 +89,7 @@ | |||
"react-datetime": "2.9.0", | |||
"react-dom": "^15.6.2", | |||
"react-gravatar": "^2.6.1", | |||
"react-grid-layout": "^0.16.0", | |||
"react-grid-layout": "0.16.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment on the following line? Since JSON doesn't support comments, the best way might be to:
"//": "react-grid-layout 0.16.6 has know issue described in #4596"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hopefully yarn
and npm
won't try to reorder the comment. Related: https://stackoverflow.com/questions/14221579/how-do-i-add-comments-to-package-json-for-npm-install
LGTM |
(cherry picked from commit 8951990)
Cherrypick: [BugFix] Resizing widgets problem apache#4596 (apache#4597)
@mistercrunch why not use this version "react-grid-layout": "^0.16.0", we prefer this version since charts won't move around while dragging one chart through other charts |
@yamyamyuo we don't use |
@mistercrunch when does this version coming out? I just curious why the superset recent releases (eg. 0.26.2, 0.26.3) contains bugs that were found half year ago(like this one)? Does the new release version generate from master? |
@mistercrunch and one more question, what does the suffix means in release |
react-grid-layout 0.16.6 causes an issue with resizing the widget. See more ... #4596.