Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Resizing widgets problem #4596

Closed
oxydash opened this issue Mar 11, 2018 · 2 comments
Closed

[Bug] Resizing widgets problem #4596

oxydash opened this issue Mar 11, 2018 · 2 comments

Comments

@oxydash
Copy link
Contributor

oxydash commented Mar 11, 2018

Make sure these boxes are checked before submitting your issue - thank you!

  • [x ] I have checked the superset logs for python stacktraces and included it here as text if any
  • [x ] I have reproduced the issue with at least the latest released version of superset
  • [x ] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version

master
0.23.2

Expected results

The possibility to change widgets' sizes without destroying the while order

Actual results

I am facing a problem which lasts about 5 days. After compiling the project about 5 days ago, resizing of some widgets leads now to random order of all other widgets, in other words it’s impossible to change size of some widgets without destroying the whole order, as it is shown in video. The problem concerns also stable branches, that didn’t happen earlier. I suppose, that this may be caused by the third-party framework update.

bug resize widget

Steps to reproduce

  1. Compile project (branch: master or 0.23.2) (yarn & yarn run prod)
  2. Try to change the widgets' sizes in the existing dashboards
@mistercrunch
Copy link
Member

@williaster and @graceguo-supercat are working on a completely new layout scheme for the dashboards that uses drag and drop and moves us away from the current react-grid-layout.

From my understanding the issue you describe are specific to react-grid-layout and could be handled there, though as I said we're moving away from that library.

The new dashboard layout will have native support for dashboard-specific constructs like tabs, sections, rows, filters and more. I'm excited for scoped-filters that will apply only within their context (global, tab, section, chart, ...)

oxydash pushed a commit to oxydash/superset that referenced this issue Mar 11, 2018
oxydash pushed a commit to oxydash/superset that referenced this issue Mar 11, 2018
@oxydash
Copy link
Contributor Author

oxydash commented Mar 11, 2018

Thanks for the help! The package react-grid-layout ver.0.16.6 is to blame. I'm looking forward to the new dashboard.

@oxydash oxydash closed this as completed Mar 11, 2018
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this issue Mar 12, 2018
graceguo-supercat pushed a commit to airbnb/superset-fork that referenced this issue Mar 12, 2018
michellethomas pushed a commit to michellethomas/panoramix that referenced this issue May 24, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this issue Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants