Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[translate] finish and update Chinese translate file #3714

Closed
wants to merge 5 commits into from
Closed

[translate] finish and update Chinese translate file #3714

wants to merge 5 commits into from

Conversation

zhouyao1994
Copy link
Contributor

[translate] finish and updateC hinese translate file and a add some lables that have been use in show Database View

@coveralls
Copy link

coveralls commented Oct 25, 2017

Coverage Status

Coverage remained the same at 71.352% when pulling 419cc90 on zhouyao1994:translate_zh into 547a3bf on apache:master.

@zhouyao1994
Copy link
Contributor Author

[Translate] translate into chinese

@xrmx
Copy link
Contributor

xrmx commented Oct 25, 2017

Rebase against master please, you are reverting recently updated files.

@@ -2477,13 +2477,13 @@ msgid "Choose a target"
msgstr ""

#: superset/assets/javascripts/explore/stores/visTypes.js:828
msgid "ISO 3166-2 codes of region/province/department"
msgid "ISO 3166-1 codes of region/province/department"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you want to change this

Copy link
Contributor Author

@zhouyao1994 zhouyao1994 Oct 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry since i delected this branch ,so i re commit a PR in #3717 @xrmx

msgstr ""

#: superset/assets/javascripts/explore/stores/visTypes.js:829
msgid ""
"It's ISO 3166-2 of your region/province/department in your table. (see "
"documentation for list of ISO 3166-2)"
"It's ISO 3166-1 of your region/province/department in your table. (see "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants