Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[translate]Translate the po file into chinese #3717

Closed
wants to merge 21 commits into from
Closed

[translate]Translate the po file into chinese #3717

wants to merge 21 commits into from

Conversation

zhouyao1994
Copy link
Contributor

[translate]Translate the po file into chinese

and regenarate po file from.source code

@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.352% when pulling 6b89df27e5f9edcd4649570838c0f80ff62813be on zhouyao1994:translate_zh into 547a3bf on apache:master.

1 similar comment
@coveralls
Copy link

coveralls commented Oct 25, 2017

Coverage Status

Coverage remained the same at 71.352% when pulling 6b89df27e5f9edcd4649570838c0f80ff62813be on zhouyao1994:translate_zh into 547a3bf on apache:master.

@xrmx
Copy link
Contributor

xrmx commented Oct 25, 2017

FYI you don't need to open a new PR just push the changes to the same branch and the PR will update.

@zhouyao1994
Copy link
Contributor Author

@xrmx sorry~ this is my first time to commit my code. thank you mind me。

Can I push requer my code in this PR since the prev PR branch had been deleted.

@coveralls
Copy link

coveralls commented Oct 26, 2017

Coverage Status

Coverage remained the same at 71.352% when pulling 9eca92b on zhouyao1994:translate_zh into 9432ea8 on apache:master.

@zhouyao1994
Copy link
Contributor Author

@magicansk I add the Chinese-Traditional lang but I can't see in my browser, is that has some font problem? can you test it ? thank you ~

@zhouyao1994 zhouyao1994 mentioned this pull request Oct 26, 2017
@coveralls
Copy link

coveralls commented Oct 26, 2017

Coverage Status

Coverage remained the same at 71.352% when pulling 49d170c on zhouyao1994:translate_zh into 9432ea8 on apache:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.352% when pulling 49d170c on zhouyao1994:translate_zh into 9432ea8 on apache:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.352% when pulling 49d170c on zhouyao1994:translate_zh into 9432ea8 on apache:master.

@magicansk
Copy link
Contributor

Hi, @zhouyao1994

  • Can you more specifically your problem?
  • And what do you wanna me to test the feature in # 3717?
    Thanks

@zhouyao1994
Copy link
Contributor Author

zhouyao1994 commented Oct 26, 2017

thank you reply.i add a Chinese-Traditional lang suport in it but i can't see it.
Does you first langues is Chinese-tranditianl?
I just see you commit a with some Chinese word.

it doesn't work with Chinese-tranditianl but it work with Chinese-simple.
I don't know why.
if you can help me .
thank you very much.

it doesn't work with Chinese-tranditianl
2017-10-26_03
but it work with Chinese-simple also work with Janpanese languages.
2017-10-26_04

2017-10-26_05

@magicansk
Copy link
Contributor

Hi @zhouyao1994,
What URL exactly you are looking at?
It looks fine in my browser both simple Chinese and traditional Chinese or others languages.
Possibly, the problems are caused by your browser or country(China) may block the zh-TW in alternative ways. It's not the problem by traditional Chinese.

@zhouyao1994
Copy link
Contributor Author

Hi @magicansk
ok that's Good. thank you very much~
My code is running at local host .so it's not work when i send my url to you!

@zhouyao1994
Copy link
Contributor Author

【translate】add Chinese-TW langua and try to translate more in Chinese

@zhouyao1994
Copy link
Contributor Author

@graceguo-supercat can you review this code that i commit in This PR?

@zhouyao1994
Copy link
Contributor Author

@mistercrunch #3717 have PR few days。

  1. Is there some code unproper in my translate file?
  2. why there is no translate folder when i install superset throught pip tool? I am work in ubuntu 17.04 python3.5.3 virtualenv.

i used superset set for a few mouth,it's very good I really want to be able to make comtribution to the community.
so i I'm looking forward to your merging my code.

thank you very much!

@graceguo-supercat
Copy link

@zhouyao1994 Thank you for the contribution. Sorry for the delay, because we have another translation PR #3750 and #3745, I just want to make sure all new translations are put into right place.

Please resolve conflicts, and then I can merge it. Thank you!

mistercrunch and others added 8 commits November 5, 2017 11:55
fixes #3507

This prevents malformed JSON from getting saved in a slice's params. It
also prevents the issue described in #3507 from happening though as a
result malformed slices will render using default control values.
A shortcut to make it easy to refresh a table's schema
1. avoid exports is not defined error
2. per jordan's suggestion, update .babelrc only use airbnb presets
* Reorders MANIFEST.in

* Includes the translations dir in MANIFEST
Dialect's has_table method requires connection as the first argument, not engine (https://github.com/zzzeek/sqlalchemy/blob/master/lib/sqlalchemy/engine/interfaces.py#L454). Instead, we can use engine's has_table method that handles the connection for us (https://github.com/zzzeek/sqlalchemy/blob/master/lib/sqlalchemy/engine/base.py#L2141). Alternatively, we could call engine.dialect.has_table(engine.connect(), ...).
mistercrunch and others added 11 commits November 5, 2017 11:55
Move all translation config to superset/translations
In `assets/static` we have a symlink pointing to `docs/_build/html`
which is .gitignored and missing in the repo since we don't want the
html-generated docs in the repo, meaning the symlink is broken

Having the symlink broken creates issues with pip-compile somehow.

Adding a dummy file here addresses that
So we stop confusing people that thinks we do DDL.

Fix #3761
update to 1.9

I have built and pip installed with latest cryptography.
* [time table] add tooltip to sparkline

* [time table] open link in new tab

* [time table] add back Mustache
@zhouyao1994
Copy link
Contributor Author

@graceguo-supercat i just rebase on the latest code in master and sovle the conflices .But,it seems that so many changes have been commit. Is that the right thing to do?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 71.271% when pulling 82b7834 on zhouyao1994:translate_zh into 9432ea8 on apache:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 71.271% when pulling 82b7834 on zhouyao1994:translate_zh into 9432ea8 on apache:master.

@coveralls
Copy link

coveralls commented Nov 5, 2017

Coverage Status

Coverage decreased (-0.08%) to 71.271% when pulling 82b7834 on zhouyao1994:translate_zh into 9432ea8 on apache:master.

@graceguo-supercat
Copy link

graceguo-supercat commented Nov 6, 2017

@zhouyao1994 You can do a rebase or merge to pick up all latest change. Please double check you didn't overwrite other contributors' code. Also under Files Changed sections, it should only contains files that you changed. Thank you!

@kristw kristw added the inactive Inactive for >= 30 days label Jan 23, 2019
@stale stale bot closed this Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive Inactive for >= 30 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.