-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature/Bugfix] Datepicker and time granularity options to dashboard filters #3508
[Feature/Bugfix] Datepicker and time granularity options to dashboard filters #3508
Conversation
Coverage decreased (-0.04%) to 69.5% when pulling 973e2ab370476084717a5d1e2a4fe9e373708739 on Mogball:mogball/feature/dashboard_filter into 9af34ba on apache:master. |
Coverage decreased (-0.07%) to 69.464% when pulling 0a6779420bb7efaf36d8d1c93ab903d5170e0b56 on Mogball:mogball/feature/dashboard_filter into 9af34ba on apache:master. |
2 similar comments
Coverage decreased (-0.07%) to 69.464% when pulling 0a6779420bb7efaf36d8d1c93ab903d5170e0b56 on Mogball:mogball/feature/dashboard_filter into 9af34ba on apache:master. |
Coverage decreased (-0.07%) to 69.464% when pulling 0a6779420bb7efaf36d8d1c93ab903d5170e0b56 on Mogball:mogball/feature/dashboard_filter into 9af34ba on apache:master. |
0a67794
to
2ce6514
Compare
Coverage increased (+0.08%) to 69.613% when pulling 2ce6514450f5d37f657168fa1ce90824378c9015 on Mogball:mogball/feature/dashboard_filter into 9af34ba on apache:master. |
1 similar comment
Coverage increased (+0.08%) to 69.613% when pulling 2ce6514450f5d37f657168fa1ce90824378c9015 on Mogball:mogball/feature/dashboard_filter into 9af34ba on apache:master. |
2ce6514
to
089cad4
Compare
48df6ff
to
d764fd2
Compare
@mistercrunch this fixes a regression in 0.20.0 #3522 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is assuming that everyone that wants to expose time filters also wants to expose granularity
and time column
in their filter box, which may not be the case. It may also be the case that it would push down other filters that were visible towards a place you may have to scroll to, which could create confusion on existing dashboards.
I think we should add 2 checkboxes to filter_box: Show Granularity Dropown
and Show Time Column
, both false by default
@mistercrunch There were already checkboxes for |
c354c90
to
e9b4f87
Compare
Once this gets merged in, would it be possible to release a new superset version ( |
2 similar comments
@joshwalters I usually like to bake releases in Airbnb's production for at least 24 hours, but in this case I should probably cut a branch and cherry pick this on top of |
… filters (apache#3508) * Feature: added datepicker and time granularity options to dashboard filter * Added option for Druid datasource time filters * added more checkbox control over dashboard time filters
As per #1718 and #183, PR adds the ability to set the Time Column (
granularity_sqla
) and Time Grain (time_grain_sqla
) filters from a dashboard filter, or Time Granularity (granularity
) and Origin (druid_time_origin
).These can be enabled by checking the appropriate boxes in the explore view:
Also, the standard drop-down menus for
from
andto
have been replaced with the same datepicker used forSince
andUntil
for explore control panels.EDIT: also addresses #3522