Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/Bugfix] Datepicker and time granularity options to dashboard filters #3508

Merged

Conversation

Mogball
Copy link
Contributor

@Mogball Mogball commented Sep 21, 2017

As per #1718 and #183, PR adds the ability to set the Time Column (granularity_sqla) and Time Grain (time_grain_sqla) filters from a dashboard filter, or Time Granularity (granularity) and Origin (druid_time_origin).

datepicker_filter

These can be enabled by checking the appropriate boxes in the explore view:

screen shot 2017-10-03 at 12 46 28 pm

Also, the standard drop-down menus for from and to have been replaced with the same datepicker used for Since and Until for explore control panels.

EDIT: also addresses #3522

@coveralls
Copy link

coveralls commented Sep 21, 2017

Coverage Status

Coverage decreased (-0.04%) to 69.5% when pulling 973e2ab370476084717a5d1e2a4fe9e373708739 on Mogball:mogball/feature/dashboard_filter into 9af34ba on apache:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 69.464% when pulling 0a6779420bb7efaf36d8d1c93ab903d5170e0b56 on Mogball:mogball/feature/dashboard_filter into 9af34ba on apache:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 69.464% when pulling 0a6779420bb7efaf36d8d1c93ab903d5170e0b56 on Mogball:mogball/feature/dashboard_filter into 9af34ba on apache:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 69.464% when pulling 0a6779420bb7efaf36d8d1c93ab903d5170e0b56 on Mogball:mogball/feature/dashboard_filter into 9af34ba on apache:master.

@Mogball Mogball force-pushed the mogball/feature/dashboard_filter branch from 0a67794 to 2ce6514 Compare September 21, 2017 03:19
@Mogball Mogball closed this Sep 21, 2017
@Mogball Mogball reopened this Sep 21, 2017
@coveralls
Copy link

coveralls commented Sep 21, 2017

Coverage Status

Coverage increased (+0.08%) to 69.613% when pulling 2ce6514450f5d37f657168fa1ce90824378c9015 on Mogball:mogball/feature/dashboard_filter into 9af34ba on apache:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 69.613% when pulling 2ce6514450f5d37f657168fa1ce90824378c9015 on Mogball:mogball/feature/dashboard_filter into 9af34ba on apache:master.

@Mogball Mogball force-pushed the mogball/feature/dashboard_filter branch from 2ce6514 to 089cad4 Compare September 21, 2017 04:43
@Mogball Mogball closed this Sep 21, 2017
@Mogball Mogball reopened this Sep 21, 2017
@coveralls
Copy link

coveralls commented Sep 21, 2017

Coverage Status

Coverage increased (+0.08%) to 69.613% when pulling 089cad4 on Mogball:mogball/feature/dashboard_filter into 9af34ba on apache:master.

@Mogball Mogball force-pushed the mogball/feature/dashboard_filter branch from 48df6ff to d764fd2 Compare September 21, 2017 22:46
@coveralls
Copy link

coveralls commented Sep 21, 2017

Coverage Status

Coverage increased (+0.09%) to 69.622% when pulling d764fd2 on Mogball:mogball/feature/dashboard_filter into 9af34ba on apache:master.

@coveralls
Copy link

coveralls commented Sep 21, 2017

Coverage Status

Coverage increased (+0.08%) to 69.613% when pulling d764fd2 on Mogball:mogball/feature/dashboard_filter into 9af34ba on apache:master.

@coveralls
Copy link

coveralls commented Sep 26, 2017

Coverage Status

Coverage increased (+0.08%) to 70.009% when pulling 17fda32 on Mogball:mogball/feature/dashboard_filter into 7d934e7 on apache:master.

@xrmx
Copy link
Contributor

xrmx commented Sep 29, 2017

@mistercrunch this fixes a regression in 0.20.0 #3522

Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is assuming that everyone that wants to expose time filters also wants to expose granularity and time column in their filter box, which may not be the case. It may also be the case that it would push down other filters that were visible towards a place you may have to scroll to, which could create confusion on existing dashboards.

I think we should add 2 checkboxes to filter_box: Show Granularity Dropown and Show Time Column, both false by default

@Mogball
Copy link
Contributor Author

Mogball commented Oct 3, 2017

@mistercrunch There were already checkboxes for SQL Time Filters and Druid Time Filters, nevertheless, I split them up to have one checkbox for each: granularity_sqla, time_column, granularity, and druid_time_origin, all false by default.

@Mogball Mogball closed this Oct 3, 2017
@Mogball Mogball reopened this Oct 3, 2017
@Mogball Mogball force-pushed the mogball/feature/dashboard_filter branch from c354c90 to e9b4f87 Compare October 3, 2017 20:00
@joshwalters
Copy link
Contributor

Once this gets merged in, would it be possible to release a new superset version (0.20.2), as it looks like other people are running into problems with this: #3522

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 70.225% when pulling e9b4f87 on Mogball:mogball/feature/dashboard_filter into 18e459e on apache:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 70.225% when pulling e9b4f87 on Mogball:mogball/feature/dashboard_filter into 18e459e on apache:master.

@coveralls
Copy link

coveralls commented Oct 3, 2017

Coverage Status

Coverage increased (+0.08%) to 70.225% when pulling e9b4f87 on Mogball:mogball/feature/dashboard_filter into 18e459e on apache:master.

@coveralls
Copy link

coveralls commented Oct 3, 2017

Coverage Status

Coverage increased (+0.08%) to 70.225% when pulling e9b4f87 on Mogball:mogball/feature/dashboard_filter into 18e459e on apache:master.

@Mogball Mogball changed the title Feature: Datepicker and time granularity options to dashboard filters [Feature/Bugfix] Datepicker and time granularity options to dashboard filters Oct 4, 2017
@mistercrunch mistercrunch merged commit 7c936e7 into apache:master Oct 4, 2017
@mistercrunch
Copy link
Member

@joshwalters I usually like to bake releases in Airbnb's production for at least 24 hours, but in this case I should probably cut a branch and cherry pick this on top of 0.12.1

@Mogball Mogball mentioned this pull request Oct 6, 2017
3 tasks
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
… filters (apache#3508)

* Feature: added datepicker and time granularity options to dashboard filter

* Added option for Druid datasource time filters

* added more checkbox control over dashboard time filters
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.2 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants