Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date Filter is not working on dashboard. #3522

Closed
3 tasks done
thakur00mayank opened this issue Sep 25, 2017 · 10 comments
Closed
3 tasks done

Date Filter is not working on dashboard. #3522

thakur00mayank opened this issue Sep 25, 2017 · 10 comments

Comments

@thakur00mayank
Copy link

thakur00mayank commented Sep 25, 2017

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if any
  • I have reproduced the issue with at least the latest released version of superset
  • I have checked the issue tracker for the same issue and I haven't found one similar

Superset version

Git Hash: 255ea69

Expected results

When we change the date filter, other slices in the dashboard should be updated according to date filter.

Actual results

When we change the date filter, other slices in the dashboard doesn't get updated according to date filter.

Steps to reproduce

  1. Create the date filter slice, enable the Date Filter inside options. Select the proper time column inside Time section, let's say it is Date.

  2. Now create another slice whose datasource contains the Date column.

    2.1. Select the proper datasource.

    2.2. Select chart type as distributed bar chart.

    2.3. Select the proper Time Column, lets say it is Date.

    2.4 Select the other options of the chart.

  3. Add these two slices in a dashboard.

  4. Change the date filter with valid from and to.

  5. Other slices on the dashboard don't get updated according to Date filter.

@thakur00mayank
Copy link
Author

thakur00mayank commented Sep 25, 2017

I think, this has been generated due to this commit.
As this has removed the extra_filter from form_data at UI side, but "superset/viz.py -> BaseViz -> get_extra_filters " is still fetching the extra_filters from form_data.get('extra_filters', []).

@xrmx
Copy link
Contributor

xrmx commented Sep 25, 2017

@thakur00mayank Next time if you are not using a release please mention the git hash you are using, thanks.

@thakur00mayank
Copy link
Author

@xrmx Thanks for the suggestion. I have mentioned the git hash in the reported issue.

@DaimonPl
Copy link

We are having same problem after upgrading to 0.20.0

@xrmx
Copy link
Contributor

xrmx commented Sep 29, 2017

@Mogball any chance you can take a look at this please?

@Mogball
Copy link
Contributor

Mogball commented Sep 29, 2017

That would be my fault, but I fixed this in #3508

@xrmx
Copy link
Contributor

xrmx commented Sep 29, 2017

@Mogball Thanks for the update!

@DaimonPl
Copy link

DaimonPl commented Oct 2, 2017

@Mogball @xrmx great there's fix for that :) any chance to have it merged and released as 0.20.1 ? It's quite critical bug as all dashboards with date filters stopped working with 0.20.0

@satishbhor
Copy link

@Mogball Same issue for me, any idea when #3508 will be released?

@DaimonPl
Copy link

With 0.20.4 it works fine for us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants