-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: CSV File Upload form updates (Grouping with Collapse/Expand) #21992
Conversation
dd9b167
to
42e3fe5
Compare
Codecov Report
@@ Coverage Diff @@
## master #21992 +/- ##
==========================================
- Coverage 66.85% 66.10% -0.75%
==========================================
Files 1841 1841
Lines 70197 70230 +33
Branches 7662 7664 +2
==========================================
- Hits 46927 46426 -501
- Misses 21296 21817 +521
- Partials 1974 1987 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
42e3fe5
to
1be6399
Compare
- Add expand/collapse to sections uisng custom macros - Add other delimiter text input using custom macros - Add custom jquery scripts to support our new features
- Add has_access decorator to new custom view so it is secure
1be6399
to
236d0c1
Compare
- Fix formatting
SUMMARY
This is a follow up PR based on #21922 (So I'd suggest checking that one first so we can rebase this PR). Here we are grouping some input groups into collapsable sections, so our users can have a better experience while uploading CSV files. Since this level of customization escape from FAB default views, we are creating a new one and adding the correspondent templates with macros.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
test.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION