Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: CSV File Upload form updates #21922

Merged
merged 5 commits into from
Nov 21, 2022
Merged

feat: CSV File Upload form updates #21922

merged 5 commits into from
Nov 21, 2022

Conversation

Antonio-RiveroMartnez
Copy link
Member

@Antonio-RiveroMartnez Antonio-RiveroMartnez commented Oct 24, 2022 •
edited
Loading

SUMMARY

This is going to be the first of a set of PRs to improve the experience for our users in the CSV file upload form. Here we are reordering some fields of the form and changing their Name and descriptions.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
https://user-images.githubusercontent.com/38889534/198689750-2996d449-af67-43f6-b75f-94c79c913960.mov

After:
https://user-images.githubusercontent.com/38889534/198690113-03a711d0-f903-484e-a844-cae9fda8a8eb.mov

TESTING INSTRUCTIONS

  1. Open the CSV file upload form
  2. Check the form matches the proposed changes

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 24, 2022 •
edited
Loading

Codecov Report

Merging #21922 (863f2b3) into master (e990690) will not change coverage.
The diff coverage is 70.58%.

@@           Coverage Diff           @@
##           master   #21922   +/-   ##
=======================================
  Coverage   67.00%   67.00%           
=======================================
  Files        1835     1835           
  Lines       69971    69971           
  Branches     7588     7588           
=======================================
  Hits        46882    46882           
  Misses      21123    21123           
  Partials     1966     1966
Flag Coverage Δ
hive 52.60% <70.58%> (ø)
mysql 78.13% <70.58%> (ø)
postgres 78.20% <70.58%> (ø)
presto 52.49% <70.58%> (ø)
python 81.39% <70.58%> (ø)
sqlite 76.66% <70.58%> (ø)
unit 50.89% <70.58%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/database/views.py 31.36% <0.00%> (ø)
superset/views/database/forms.py 85.71% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Antonio-RiveroMartnez Antonio-RiveroMartnez changed the title [Draft] feat: CSV File Upload form updates feat: CSV File Upload form updates Oct 28, 2022
@hughhhh hughhhh self-requested a review October 28, 2022 20:09
@Antonio-RiveroMartnez Antonio-RiveroMartnez mentioned this pull request Nov 1, 2022
Merged
8 tasks
@eschutho
Copy link
Member

eschutho commented Nov 1, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

@eschutho Ephemeral environment spinning up at http://35.90.79.196:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

eschutho
eschutho approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great. Will defer to @jinghua-qa or @yousoph for visual review.

@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@jinghua-qa
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@jinghua-qa Ephemeral environment spinning up at http://34.217.78.232:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@Antonio-RiveroMartnez
CSV Upload:
0e47554 
- Update field texts: Name & Descriptions
- Reorder form fields
- Update tests
@Antonio-RiveroMartnez
CSV Upload:
522e9d7 
- Fix typo in Null Values field
@Antonio-RiveroMartnez
CSV Upload:
0a0e390 
- Make description for Null Values field match the mock up
@Antonio-RiveroMartnez
CSV Upload:
25322b3 
- Rename the id of the DOm element so it doesn't fail when querying schemas with allowed csv file upload
@Antonio-RiveroMartnez
CSV Upload:
863f2b3 
- The DOM element was still misnamed in one place
@andrey-zayats
Copy link

LGTM!

@hughhhh hughhhh merged commit 6bb4d87 into apache:master Nov 21, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added the 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eschutho eschutho eschutho approved these changes

@hughhhh hughhhh Awaiting requested review from hughhhh

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Antonio-RiveroMartnez @eschutho @jinghua-qa @andrey-zayats @mistercrunch @hughhhh