Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Changes the no-literal-colors lint rule to throw errors instead of warnings #20034

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Changes the no-literal-colors lint rule to throw errors instead of warnings.

The following PRs removed the hard-coded colors from the codebase allowing this rule to be changed: #20006, #20016, #19923, #19493, #19466, #19443, #19439

TESTING INSTRUCTIONS

Check that there are no literal color lint-related errors.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina force-pushed the error-on-no-literal-colors branch from 299580e to 6150cc3 Compare May 12, 2022 13:24
@michael-s-molina michael-s-molina marked this pull request as ready for review May 12, 2022 13:24
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #20034 (af93975) into master (c4c714f) will not change coverage.
The diff coverage is n/a.

❗ Current head af93975 differs from pull request most recent head 6150cc3. Consider uploading reports for the commit 6150cc3 to get more accurate results

@@           Coverage Diff           @@
##           master   #20034   +/-   ##
=======================================
  Coverage   66.35%   66.35%           
=======================================
  Files        1712     1712           
  Lines       64083    64083           
  Branches     6744     6744           
=======================================
  Hits        42523    42523           
  Misses      19847    19847           
  Partials     1713     1713           
Flag Coverage Δ
javascript 51.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4c714f...6150cc3. Read the comment docs.

@michael-s-molina michael-s-molina merged commit a051d91 into apache:master May 12, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants