Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Removes hard-coded colors from the plugins - iteration 2 #20006

Merged
merged 2 commits into from
May 12, 2022
Merged

chore: Removes hard-coded colors from the plugins - iteration 2 #20006

merged 2 commits into from
May 12, 2022

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Replaces hard-coded colors with colors from the theme.

TESTING INSTRUCTIONS

Open the plugins' storybook
Check the changed plugins

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina removed the request for review from kgabryje May 9, 2022 21:01
michael-s-molina
michael-s-molina commented May 9, 2022
View reviewed changes
superset-frontend/plugins/preset-chart-xy/src/components/Line/Encoder.ts
@@ -46,7 +46,7 @@ export const lineEncoderFactory = createEncoderFactory<LineEncodingConfig>({
x: { field: 'x', type: 'quantitative' },
y: { field: 'y', type: 'quantitative' },
fill: { value: false, legend: false },
stroke: { value: '#222' },
stroke: { value: '#222' }, // eslint-disable-line theme-colors/no-literal-colors
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disabled the rule here because it seems this Line chart is deprecated. Can you confirm @villebro @zhaoyongjie?

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #20006 (68b6990) into master (62e1c34) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #20006   +/-   ##
=======================================
  Coverage   66.28%   66.29%           
=======================================
  Files        1712     1712           
  Lines       63968    63971    +3     
  Branches     6731     6731           
=======================================
+ Hits        42404    42407    +3     
  Misses      19853    19853           
  Partials     1711     1711
Flag Coverage Δ
javascript 51.27% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../plugin-chart-echarts/src/Funnel/transformProps.ts 71.73% <ø> (ø)
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.00% <ø> (ø)
...ins/plugin-chart-echarts/src/Pie/transformProps.ts 55.07% <ø> (ø)
...s/plugin-chart-echarts/src/Radar/transformProps.ts 0.00% <ø> (ø)
...gin-chart-echarts/src/Timeseries/transformProps.ts 57.89% <ø> (ø)
...lugin-chart-echarts/src/Timeseries/transformers.ts 51.63% <ø> (ø)
...plugin-chart-echarts/src/Treemap/transformProps.ts 51.51% <ø> (ø)
...ins/preset-chart-xy/src/components/Line/Encoder.ts 100.00% <ø> (ø)
...ns/legacy-plugin-chart-map-box/src/controlPanel.ts 33.33% <100.00%> (+8.33%) ⬆️
...BigNumber/BigNumberWithTrendline/transformProps.ts 46.96% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62e1c34...68b6990. Read the comment docs.

@michael-s-molina michael-s-molina mentioned this pull request May 11, 2022
Merged
9 tasks
kgabryje
kgabryje approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina merged commit c4c714f into apache:master May 12, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@michael-s-molina @philipher29
chore: Removes hard-coded colors from the plugins - iteration 2 (apac…
43f7364 
…he#20006)

* chore: Removes hard-coded colors from the plugins - iteration 2

* Fixes lint errors
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgabryje kgabryje kgabryje approved these changes

@rusackas rusackas Awaiting requested review from rusackas

@villebro villebro Awaiting requested review from villebro

@geido geido Awaiting requested review from geido

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-s-molina @kgabryje @mistercrunch