fix: Remove gap from SQLLab results bottom #19138
Conversation
| @@ -152,7 +152,7 @@ export default function SouthPane({ | |||
| query={latestQuery} | |||
| actions={actions} | |||
| user={user} | |||
| height={innerTabContentHeight} | |||
| height={innerTabContentHeight + 24} | |||
There was a problem hiding this comment.
could we add this to a constant at the top of the file? and explain in code why this is needed?
Alternatively, where does innerTabContentHeight come from? Is there some alteration that needs to be made there instead?
There was a problem hiding this comment.
I did some inveestigation about innerTabContentHeight, but no way to handle it dynamically.
I will add constant value at the top of the file. 👍
|
Looks like CI is failing? If it's not related to your PR, maybe try rebasing? |
It is not related to my pr, also not related to rebasing stuff as well, I think rerunning may help? |
| @@ -152,7 +154,7 @@ export default function SouthPane({ | |||
| query={latestQuery} | |||
| actions={actions} | |||
| user={user} | |||
| height={innerTabContentHeight} | |||
| height={innerTabContentHeight + EXTRA_HEIGHT_RESULTS} | |||
There was a problem hiding this comment.
@rusackas we should add a story to rework these components, as they should use flexbox instead of manually calculating heights
There was a problem hiding this comment.
Feel free to add one into the backlog. I seem to recall looking at this before, but there was some sort of wrinkle in implementing the library used to allow draggable resizing of the top/bottom panes.
There was a problem hiding this comment.
oh yeah, good call. We can take a look down the road
|
Actually this needs a rebase, and note that the conflict is due to some new styles... one of which has a |
Codecov Report
@@ Coverage Diff @@
## master #19138 +/- ##
=======================================
Coverage 66.64% 66.64%
=======================================
Files 1674 1674
Lines 64614 64615 +1
Branches 6502 6502
=======================================
+ Hits 43061 43062 +1
Misses 19868 19868
Partials 1685 1685
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* Remove gap from SQLLab results bottom * resolve comment (cherry picked from commit 8947eb9)
* Remove gap from SQLLab results bottom * resolve comment
mistercrunch
added
🍒 1.5.0
🍒 1.5.1
🍒 1.5.2
🍒 1.5.3
🏷️ bot
SUMMARY
The table height was being calculated manually inside code, but it was based on the calculation in PREVIEW table.
In the RESULT tab, we need some correction to remove the gaps.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION