Skip to content

Commit

Permalink
fix: Remove gap from SQLLab results bottom (apache#19138)
Browse files Browse the repository at this point in the history
* Remove gap from SQLLab results bottom

* resolve comment
  • Loading branch information
codemaster08240328 authored and philipher29 committed Jun 9, 2022
1 parent bbb8995 commit fd7d1eb
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion superset-frontend/src/SqlLab/components/SouthPane/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ const StyledPane = styled.div`
}
`;

const EXTRA_HEIGHT_RESULTS = 24; // we need extra height in RESULTS tab. because the height from props was calculated based on PREVIEW tab.
const StyledEmptyStateWrapper = styled.div`
height: 100%;
.ant-empty-image img {
Expand Down Expand Up @@ -164,7 +165,7 @@ export default function SouthPane({
query={latestQuery}
actions={actions}
user={user}
height={innerTabContentHeight}
height={innerTabContentHeight + EXTRA_HEIGHT_RESULTS}
database={databases[latestQuery.dbId]}
displayLimit={displayLimit}
defaultQueryLimit={defaultQueryLimit}
Expand Down

0 comments on commit fd7d1eb

Please sign in to comment.