fix(Dashboard): Only apply changes when editing properties

[geido]

SUMMARY

This PR adds the onlyApply prop to the properties modal of the Dashboard, so that changes will only be applied but not saved. This is to avoid confusion with discarded changes that were actually saved.

BEFORE

Fixes #17243

AFTER

Test.3.mp4

TESTING INSTRUCTIONS

1. Open a Dashboard
2. Edit its properties and apply
3. Discard the changes
4. Make sure the changes were actually discarded

ADDITIONAL INFORMATION

• Has associated issue: [Dashboard] Color scheme won't be discarded when discarding changes #17243
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #17392 (c07c0cb) into master (8f9cea8) will increase coverage by 0.01%.
The diff coverage is 87.50%.

❗ Current head c07c0cb differs from pull request most recent head 0aa5513. Consider uploading reports for the commit 0aa5513 to get more accurate results

@@            Coverage Diff             @@
##           master   #17392      +/-   ##
==========================================
+ Coverage   77.02%   77.04%   +0.01%     
==========================================
  Files        1038     1041       +3     
  Lines       56021    56063      +42     
  Branches     7735     7738       +3     
==========================================
+ Hits        43150    43191      +41     
- Misses      12613    12614       +1     
  Partials      258      258              

Flag	Coverage Δ
javascript	71.22% <14.28%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...frontend/src/SqlLab/components/ResultSet/index.tsx	61.48% <0.00%> (ø)
...frontend/src/SqlLab/components/SqlEditor/index.jsx	54.14% <ø> (ø)
...rc/explore/components/ExploreChartHeader/index.jsx	56.52% <0.00%> (ø)
...nd/src/explore/components/ExploreViewContainer.jsx	2.08% <0.00%> (-0.04%)	⬇️
superset-frontend/src/explore/controls.jsx	30.98% <ø> (ø)
superset/charts/commands/data.py	97.95% <ø> (+1.59%)	⬆️
superset/connectors/sqla/models.py	87.97% <ø> (ø)
superset/db_engine_specs/hive.py	86.48% <0.00%> (-0.34%)	⬇️
superset/charts/data/api.py	88.48% <88.48%> (ø)
superset/charts/data/query_context_cache_loader.py	90.00% <90.00%> (ø)
... and 16 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f9cea8...0aa5513. Read the comment docs.

[geido]

/testenv up

[github-actions]

@geido Ephemeral environment spinning up at http://54.68.230.199:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[jinghua-qa]

I have a question when I set a color theme in the chart and add it to a dashboard, why I can not see the color theme information in the dashboard edit mode?

color.theme.is.empty.mov

[geido]

I have a question when I set a color theme in the chart and add it to a dashboard, why I can not see the color theme information in the dashboard edit mode?

@jinghua-qa the color scheme of the chart does not affect the color scheme of the Dashboard. Only the color scheme of the Dashboard can affect the color scheme of a Chart afaik.

[jinghua-qa]

LGTM

[michael-s-molina]

LGTM

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.

[hadiismanto]

But the content or the selection of color scheme in the chart should be the same with the dashboard right ?

Because if it is not...then your chart could become useless regarding the color scheme.....