Dashboard metadata UI save unexpected behavior

[krsnik93]

I wanted to update dashboard metadata through the UI. I changed JSON metadata and clicked save in the modal (photo 1 below). Modal closed and then I clicked Save in the dashboard header (photo 2 below).

Photo 1:

Photo 2:

Expected results

Expect changes to be applied.

Actual results

Save number 2 cancels out changes from save number 1. Way to mitigate is to do save number 1 and then, when the modal closes, hit refresh. This is not intuitive at all. Another way to mitigate could be to perform save number 1 and then click Discard changes, but I haven't tested this and it's not intuitive either.

Environment

• superset version: 1.1.0
• python version: 3.7.10

Checklist

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

[yousoph]

Should be fixed by #17392