feat(explore): ColumnSelectControl with drag-and-drop #13210

zhaoyongjie · 2021-02-18T14:27:06Z

SUMMARY

POC of Explore drag and drop query panel. scope - Groupby control only.
Todo:

styling, visual indicator for draggable columns/metrics and droppable field
glitch free when d&d quickly
add feature flag
metrics refractor + new feature(in-place saving) + d&d
ad hoc filter refractor + new feature(filter array value) + d&d
sort-by + d&d

This feature will be behind a FF until all drag & drop is implemented in all control fields.

added a new feature flage

The new FF name is ENABLE_EXPLORE_DRAG_AND_DROP, and the default value is False.

DEFAULT_FEATURE_FLAGS = {
...
...
    "ENABLE_EXPLORE_DRAG_AND_DROP": False,
}

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

multi columns groupby

multi-dimensions.mp4

single column groupby

scalar-dimension.mp4

TEST PLAN

ADDITIONAL INFORMATION

codecov-io · 2021-02-22T12:56:18Z

Codecov Report

Merging #13210 (c6e5934) into master (cd3f521) will increase coverage by 3.66%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13210      +/-   ##
==========================================
+ Coverage   77.18%   80.85%   +3.66%     
==========================================
  Files         881      300     -581     
  Lines       45499    24420   -21079     
  Branches     5447        0    -5447     
==========================================
- Hits        35119    19745   -15374     
+ Misses      10256     4675    -5581     
+ Partials      124        0     -124

Flag	Coverage Δ
cypress	`?`
hive	`79.97% <ø> (ø)`
javascript	`?`
mysql	`80.30% <ø> (ø)`
postgres	`80.34% <ø> (ø)`
presto	`80.01% <ø> (ø)`
python	`80.85% <ø> (ø)`
sqlite	`79.96% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/config.py	`90.74% <ø> (ø)`
...rontend/src/dashboard/components/DashboardGrid.jsx
...perset-frontend/src/views/CRUD/welcome/Welcome.tsx
superset-frontend/src/messageToasts/types.ts
...set-frontend/src/dashboard/reducers/datasources.js
...ntend/src/dashboard/util/getRevertedFilterScope.ts
...c/filters/components/Select/SelectFilterPlugin.tsx
...tend/src/explore/components/DisplayQueryButton.jsx
...ws/CRUD/data/savedquery/SavedQueryPreviewModal.tsx
...tend/src/SqlLab/components/ScheduleQueryButton.jsx
... and 566 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd3f521...3510e15. Read the comment docs.

junlincc · 2021-02-23T05:17:02Z

@zhaoyongjie Yongjie, thanks for the POC! super excited about it. can you add manual text plan and instruction of turning on the feature flag in description? thanks!

superset-frontend/spec/javascripts/explore/components/DatasourcePanel_spec.jsx

superset-frontend/src/explore/components/DatasourcePanel/DatasourcePanelDragWrapper.tsx

...set-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelectLabel.tsx

superset-frontend/src/explore/components/controls/DndColumnSelectControl/components/Option.tsx

kgabryje · 2021-02-23T11:39:58Z

superset-frontend/src/explore/components/DatasourcePanel.tsx

+                  metricOrColumnName={m.metric_name}
+                  type={DatasourcePanelDndType.METRIC}
+                >
+                  <MetricOption metric={m} showType />


What do you think about using a cursor: move instead of default here?

sorry, what is cursor: move on this?

I mean that here we could use cursor: move to indicate that the label is draggable

All right, I will add indicator style on this component and drop component.

The style pointer: move on the datasource panel looks strange. the UI behavior we can ask @mihir174

move.mp4

kgabryje · 2021-02-23T11:44:16Z

...set-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelectLabel.tsx

+
+  function placeHolderRenderer() {
+    return (
+      <AddControlLabel cancelHover>


Don't we want to allow users to add groupby "normally" - by selecting from options instead of drag and dropping? CC @junlincc

I guess, select control and drag and drag control need choose one of two.

Hmm, I suppose it's a product decision and we can wait for Junlin's input, but I'd go for allowing users to choose the way they want to interact with our control panel. Removing normal select in favour of dnd feels like a step back to me

The code logic of the selector is already very complicated, and it is difficult to add complex logic (such as hierarchical). I suggest referring to modern BI design.

@kgabryje thanks for suggesting!
Yes, users may take awhile to get used to the new behavior, but if we keep both select and dnd, my concern is
it will increase the complexity of the component

we have two sets of each control to maintain, also if one breaks, it will likely affect the other as well?

more overhead if we wanna introduce new feature, for example in metrics.
We could keep both until we officially turn feature flag off though and run some usability tests to compare both solutions.

(regarding dnd only vs also supporting traditional clicking the control) I personally feel it's better to offer the users the option of using the traditional approach, especially as long there is a sensible control which you can click. While e.g. Tableau AFAIK only supports dnd interaction, in that UI it makes more sense, but in Superset I feel it's still a perfectly valid path to adding filters/metrics/columns.

This contentious point is almost the same as whether we should have "+" AND "ghost" button for click-to-select, and should we still support FilterBox after having native filter.
Most of us believe that the "ghost" button is more intuitive, while many from the community still prefer the existing way for various reasons. In my roadmap google sheet, I stated that the biggest drives of implementing this feature are competitive, marketability, UX improvement.
Competitive - Tableau only offers DND, no SELECT. The question I have for ya'll is that how can we find out whether offering SELECT as well ADD any value, and what that would be? We will find out later during usability or A/B testing. This should be a decision supported by data, let's not make decision for the users.
Marketability - Self explanatory, this driver doesn't affect final decision much
User Experience - keep both under FF, run test, if having both significantly impact UX in a positive way, why not keeping both?

Cost - this is more a stakeholder question. do we want to spend 2x time to maintain 2 sets of feature that achieve basically the same goal, or do we want to spend our engineering/product/QA effort on a set of new feature that brings more value and offers higher ROI?

Let's hand over the ball to our designer @mihir174, I'm sure he will take all our feedback and come up with the best solution forusers.

@kgabryje @villebro

I understand this, and as long as this is behind a FF, I agree we can live with some temporary glitches in the feature. Some thoughts that might be relevant for Mihir when considering options:

We currently only support max 50 columns in the column list. While it's possible to filter the list, it is currently not possible to browse the full list like it is in the current select control.

If the filter and metric DND controls will support both DND and the click, it would make sense to also support select on the column control (alternatively it might make sense to disable non-DND interaction with the filter and metric controls).

We currently only support max 50 columns in the column list. While it's possible to filter the list, it is currently not possible to browse the full list like it is in the current select control.

the panel search bar is very robust which supports key word search in column & metric names, label/verbose name, description, and even warning, information. when # of column reach 50, i doubt scrolling through the list is the primary way to look for the objects.

@junlincc Trust me, most users are lazy and would not want to type. Browsing the list to add columns is probably a much more common use case than you thought. For example, in Airbnb, in one of the datasources, there are many metrics with "nights_booked" in the name, when users want to find a specific metric related to "nights_booked" but couldn't remember the exact name, even after they typed "nights_booked", they may still need to browse through more than 50 options.

Re: offering DnD only or both interactions:

I think one of the biggest advantage of Superset is the ability to create adhoc metric very easily. I'm struggling to imagine how that workflow of conveniently creating adhoc metrics/columns would look like without a popover. If we are going to build a popover anyway, why not keep both DnD and click? With proper design and abstraction, the code complexity should be manageable.

Re: code maintenance:

That said, current code indeed is very complex, and is not even in TypeScript, so I'm in support of writing the new control bit by bit from scratch. But I also think it would make sense to be generic from the get go and make sure the architecture can support all use cases---because we already have so much learning from the existing controls.

It would be nice if we can focus on collecting all feature requests first and do an architecture review (maybe in a SIP?) before diving deep into implementing the full feature for a specific control type. This POC is a good starting point to kick off the conversation, but let's make sure we get things right to avoid wasted work.

I'm also not sure how to run user testing in this case, do we ask users to choose between DnD and click? Do we do that after all features for DnD are implemented or before? What if users pick click because DnD is not easy to use enough? These controls need an overhaul anyway so I can't imagine a case where we will abandon the new solution just because of some unfavorable use feedbacks (which are probably fixable).

It is also not true that we will need to spend 2x of time to maintain two sets of features. Current select controls can have a code freeze while we work on the new controls with more advanced features and better architecture. We would probably need that to stay focused.

zhaoyongjie · 2021-02-23T13:50:44Z

@zhaoyongjie Yongjie, thanks for the POC! super excited about it. can you add manual text plan and instruction of turning on the feature flag in description? thanks!

I have added in PR description.

kgabryje · 2021-02-23T14:09:33Z

...set-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelectLabel.tsx

+  options: { string: ColumnMeta };
+}
+
+export default function DndColumnSelectLabel(props: LabelProps) {


I wonder if we could make this component more generic, so we could reuse it with filters and metrics. It'd be great if we were able to pass optionsRenderer, children and other values as props. Though I don't know if it's in scope of this PR - next iteration maybe?

This is a good question!
Code reuse can refine the logic, but it may make the logic difficult to understand. We should iterate it in the future. We have to consider all kinds of components.
e.g.

various Filter(datetime filter, numeric filter, text filter)

various dimension selection(simple dimension, dimension set, dimension hierarchy)

The current DND should be just a prototype.

(regarding making a more generic component vs a specific component) Agree with both - this should be made generic, but as a first POC behind a FF I'm ok with this being more specific and making it more generic later.

@zhaoyongjie could you elaborate on what is a dimension set and dimension hierarchy? They sound like pretty advanced feature and I'm not sure they should be a concern in implementing the first draft of a generic component.

villebro

A few comments, but the code looks really good and I feel it works very well for a prototype 👍 I feel we need to iterate on the design/UX of "ghost button" vs "plus button" vs "dnd only" functionality when adding new columns/filters/metrics, as it might cause considerable work down the road if we change this later. Also, I know this is behind a FF now, but I still can't help but feel confused by some controls having the plus/ghost button but some only supporting dnd.

villebro · 2021-02-24T13:13:05Z

...set-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelectLabel.tsx

+
+  function placeHolderRenderer() {
+    return (
+      <AddControlLabel cancelHover>


(regarding dnd only vs also supporting traditional clicking the control) I personally feel it's better to offer the users the option of using the traditional approach, especially as long there is a sensible control which you can click. While e.g. Tableau AFAIK only supports dnd interaction, in that UI it makes more sense, but in Superset I feel it's still a perfectly valid path to adding filters/metrics/columns.

villebro · 2021-02-24T14:00:44Z

superset-frontend/src/explore/components/OptionControls.tsx

+      return `dashed 1px ${theme.colors.info.dark1}`;
+    }
+    if (isOver && !canDrop) {
+      return `dashed 1px ${theme.colors.error.dark1}`;
+    }


It feels like dashed 1px doesn't stick out quite enough. IMO 2px looked better, but then the default 1 px causes this to resize when hovering in/out, so that doesn't work quite so well without addditional tuning of the default borders.

I think that we should also add an indicator for canDrop && !isOver so that user knows where he can drag a column

I think that we should also add an indicator for canDrop && !isOver so that user knows where he can drag a column

Yeah I like that idea 👍

villebro · 2021-02-24T14:02:30Z

...set-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelectLabel.tsx

+  options: { string: ColumnMeta };
+}
+
+export default function DndColumnSelectLabel(props: LabelProps) {


(regarding making a more generic component vs a specific component) Agree with both - this should be made generic, but as a first POC behind a FF I'm ok with this being more specific and making it more generic later.

villebro · 2021-02-24T14:11:33Z

...rset-frontend/src/explore/components/controls/DndColumnSelectControl/utils/optionSelector.ts

+    if (Array.isArray(values)) {
+      groupByValues = values;
+      this.isScalar = false;
+    } else {
+      groupByValues = values ? [values] : [];
+      this.isScalar = true;
+    }


This might just be me, but I feel the term scalar can cause confusion here (in mathematics a scalar is a real number, which in the context of JS would be number). I'd rather use isArray to highlight that this refers to distinguishing between arrays and non-arrays.

+1 on change this to isArray check since we may want to support other more complex option in the future (e.g. AdhocFilter and AdhocMetric).

scalar in linear algebra, relative to vector. refer to SQLAlachemy and Pandas variable naming.

isArray more straightforward, I changed this variable name.

junlincc · 2021-02-24T17:08:33Z

Additional to #13210 (comment) on whether we should keep SELECT

SELECT has limitation in realizing complex hierarchy/grouping interaction. dimension/columns, metrics grouping and hierarchy are very common BI tool which which we currently lack.
When there are multiple DROP targets, dnd help set some drop restrictions. For example, If target A is dropped, target B will not accept drop values. (There are cases in PivotTable where groupby and column restrict each other)
performance. do we need to render options in dimensions/columns and metrics twice with both?

@villebro @kgabryje @ktmud @mistercrunch let's keep the discussion going so Design can have enough information to go on. but let's merge this PR soon as it's currently blocking follow up PRs.

ktmud · 2021-02-24T22:34:01Z

@junlincc This PR was ready for review for only 2 days. I think we should not rush to merge into master for something as fundamental as this---even if it's behind a feature flag.

If it's for convenience of reviewing and unblocking future PRs, let's make a feature branch in apache/superset.

...rset-frontend/src/explore/components/controls/DndColumnSelectControl/utils/optionSelector.ts

villebro

Code LGTM

ktmud

Some suggestions on how to make things more generic in the followups. Agreed this is a nice UX for a POC.

superset-frontend/src/explore/components/DatasourcePanel.tsx

ktmud · 2021-02-25T20:04:49Z

superset-frontend/src/explore/components/DatasourcePanel/types.ts

+  type:
+    | typeof DatasourcePanelDndType.METRIC
+    | typeof DatasourcePanelDndType.COLUMN;


This should also work:

Suggested change

type:

| typeof DatasourcePanelDndType.METRIC

| typeof DatasourcePanelDndType.COLUMN;

type: DatasourcePanelDndType;

...set-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelectLabel.tsx

ktmud · 2021-02-25T20:36:25Z

...set-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelectLabel.tsx

+    },
+
+    canDrop: (item: DatasourcePanelDndItem) =>
+      !optionSelector.has(item.metricOrColumnName),


Currently only columns have a canDrop indicator when dropping to a column select control, if you drag a metric, nothing will happen. It would be nice to allow drag & drop anything to any drop area while showing a useful can't drop warning when appropriate.

E.g.

Example error messages:

Column already added

Cannot group by a metric

ktmud · 2021-02-25T23:06:27Z

superset-frontend/src/explore/components/controls/DndColumnSelectControl/types.ts

+  withCaret?: boolean;
+}
+
+export const GroupByItemType = 'groupByItem';


One way to make this more generic:

Suggested change

export const GroupByItemType = 'groupByItem';

/**

* All possible draggable items for the chart controls.

*/

export enum DndItemType {

// an existing column in table

column = 'column',

// a selected column option in ColumnSelectControl

columnOption = 'columnOption',

// an adhoc column option in ColumnSelectControl

adhocColumnOption = 'adhocColumn',

// a saved metric

metric = 'metric',

// a selected saved metric in MetricsControl

metricOption = 'metricOption',

// an adhoc metric option in MetricsControl

adhocMetricOption = 'adhocMetric',

// an adhoc filter option

filterOption = 'filterOption',

}

If a DndItemType.metric or DndItemType.metricOption is dropped to a group by (column select) control, reject and show a warning;

if a DndItemType.column or columnOption is dropped to metric control, create an adhoc metric using this column.

If a metric, metricOption, column, or columnOption is dragged to the adhoc filter control or sort by control, create a new filter using the metric or column.

ktmud · 2021-02-25T23:20:50Z

...rset-frontend/src/explore/components/controls/DndColumnSelectControl/utils/optionSelector.ts

+ */
+import { ColumnMeta } from '@superset-ui/chart-controls';
+
+export class OptionSelector {


I think it's possible to make this generic, too, so you can support complex options (adhoc metrics, etc) in the list:

import { ensureIsArray } from '@superset-ui/core'; /** * Get value from an option array. */ type GetValue<T> = ( option: T | string, index?: number, array?: (T | string)[], ) => T | string; /** * Get option from a value array. */ type GetOption<T> = ( value: T | string, index?: number, array?: (T | string)[], ) => T; /** * Select options from a known list by option value. Ignores invalid options. * * @param options - all known options, a dict of value to option. * @param selected - value of selected options * @param getValue - how to get value from each option */ export class OptionSelector<T> { options: { [key: string]: T }; /** * Selected values, always an array. * If an item is string, then we look it up from options. */ selected: (T | string)[]; getValue: GetValue<T>; getOption: GetOption<T>; constructor({ options, selected, getValue = x => x, getOption = x => (typeof x === 'string' ? this.options[x] : x), }: { options: { [key: string]: T }; selected: (T | string)[] | T | string | null; getValue?: GetValue<T>; getOption?: GetOption<T>; }) { this.options = options; this.selected = ensureIsArray(selected) .map(getValue) .filter(x => (typeof x === 'string' ? x in options : Boolean(x))); this.getOption = getOption; this.getValue = getValue; } add(option: T) { const value = this.getValue(option); if (typeof value === 'string' || value in this.options) { this.selected.push(value); } } has(option: T): boolean { return this.selected.includes(this.getValue(option)); } replace(idx: number, value: T | string) { this.selected[idx] = value; } del(idx: number) { this.selected.splice(idx, 1); } swap(a: number, b: number) { [this.selected[a], this.selected[b]] = [this.selected[b], this.selected[a]]; } /** * Return selected options from value. */ selectedOptions(): T[] { return this.selected.map(this.getOption); } } // since `isMulti` should be managed in the control state: isMulti ? optionSelector.selectedOptions() : optionSelector.selectedOptions()[0];

Just a rough prototype but you get the idea.

ktmud · 2021-02-26T00:26:29Z

...set-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelectLabel.tsx

+
+interface LabelProps extends BaseControlConfig {
+  name: string;
+  value: string[] | string | null;


I think you may still need a isMulti flag because null could represents empty select for multiple selects as well.

junlincc · 2021-02-26T01:34:17Z

🟢

junlincc · 2021-02-26T15:42:18Z

Todo: for group-by that only accepts dimensions , add red indicator for metrics drop. @zhaoyongjie

zhaoyongjie · 2021-02-26T16:10:11Z

Todo: for group-by that only accepts dimensions , add red indicator for metrics drop. @zhaoyongjie

copy that, this feature need more polish, thank you.

junlincc · 2021-03-01T16:46:14Z

@yardz
issue found
in master, once you set this feature flag to True, new Echarts Graph is not working.

To reproduce
1.

DEFAULT_FEATURE_FLAGS = {
...
...
    "ENABLE_EXPLORE_DRAG_AND_DROP": True,
}

Create a Graph by

clicking the top right + button to create new chart
Select Graph(in the last row) from the gallery
Select any dataset
create, see error.
Expected behavior

Screen.Recording.2021-03-01.at.8.41.30.AM.mov

thanks!

* initial dnd * shift group by items * lint * fix shift options * wip * wip * fix shift action * support scalar dimentions * control rename to DndColumnSelectControl * remove unused files * added feature flag * ff to False by default * fix ut * lint * improve code smell * added indicator * replace value when column is scalcar * scalar to isArray * var rename * minor fix * update dependence * minor fix

pull-request-size bot added the size/XL label Feb 18, 2021

junlincc added the explore:control Related to the controls panel of Explore label Feb 18, 2021

zhaoyongjie force-pushed the dnd_poc branch from 6c74581 to 836cf0f Compare February 19, 2021 05:58

zhaoyongjie mentioned this pull request Feb 19, 2021

feat: add dropGroupByControl apache-superset/superset-ui#967

Merged

zhaoyongjie force-pushed the dnd_poc branch from 0eda78f to 9524b58 Compare February 19, 2021 13:39

zhaoyongjie changed the title ~~feat(explore): group by Control drag-and-drop~~ feat(explore): ColumnSelectControl with drag-and-drop Feb 19, 2021

zhaoyongjie force-pushed the dnd_poc branch from ad48f58 to 58beef1 Compare February 22, 2021 12:37

zhaoyongjie marked this pull request as ready for review February 22, 2021 12:39

junlincc requested review from ktmud, mistercrunch and amitmiran137 February 23, 2021 05:12

kgabryje reviewed Feb 23, 2021

View reviewed changes

zhaoyongjie force-pushed the dnd_poc branch from 3c9039e to a61f208 Compare February 23, 2021 13:35

kgabryje reviewed Feb 23, 2021

View reviewed changes

villebro reviewed Feb 24, 2021

View reviewed changes

junlincc added the design-sys-revisit label Feb 24, 2021

villebro reviewed Feb 25, 2021

View reviewed changes

...rset-frontend/src/explore/components/controls/DndColumnSelectControl/utils/optionSelector.ts Outdated Show resolved Hide resolved

kgabryje mentioned this pull request Feb 25, 2021

feat: Implement drag and drop columns for filters #13340

Merged

6 tasks

villebro approved these changes Feb 25, 2021

View reviewed changes

junlincc added need:prioritized explore:drag&drop Related to drag&drop in Explore and removed explore:control Related to the controls panel of Explore labels Feb 25, 2021

ktmud approved these changes Feb 26, 2021

View reviewed changes

initial dnd

215124b

zhaoyongjie added 15 commits February 26, 2021 10:31

fix shift action

ad28813

support scalar dimentions

8b699d7

control rename to DndColumnSelectControl

f59bf84

remove unused files

c985c25

added feature flag

507ca47

ff to False by default

d4e2a58

fix ut

d97ed8d

lint

6b6327b

improve code smell

7296a54

added indicator

671eaed

replace value when column is scalcar

49989ea

scalar to isArray

64f8d4d

var rename

41126f6

minor fix

44d2bec

update dependence

1854cd7

zhaoyongjie force-pushed the dnd_poc branch from e248373 to 1854cd7 Compare February 26, 2021 07:09

minor fix

3510e15

zhaoyongjie merged commit 1e3130d into apache:master Feb 26, 2021

ktmud mentioned this pull request Mar 1, 2021

refactor(explore): convert ControlPanelsContainer to typescript #13221

Merged

6 tasks

This was referenced Mar 1, 2021

fix(graph): graph page error #13395

Closed

fix(graph): graph page error #13466

Closed

junlincc mentioned this pull request Mar 11, 2021

feat: Implement drag and drop for metrics #13575

Merged

6 tasks

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024

-export const GroupByItemType = 'groupByItem';
+/**
+ * All possible draggable items for the chart controls.
+ */
+export enum DndItemType {
+   // an existing column in table
+   column = 'column',
+   // a selected column option in ColumnSelectControl
+   columnOption = 'columnOption',
+   // an adhoc column option in ColumnSelectControl
+   adhocColumnOption = 'adhocColumn',
+   // a saved metric
+   metric = 'metric',
+   // a selected saved metric in MetricsControl
+   metricOption = 'metricOption',
+   // an adhoc metric option in MetricsControl
+   adhocMetricOption = 'adhocMetric',
+   // an adhoc filter option
+   filterOption = 'filterOption',
+ }

feat(explore): ColumnSelectControl with drag-and-drop #13210

feat(explore): ColumnSelectControl with drag-and-drop #13210

Conversation

zhaoyongjie commented Feb 18, 2021 • edited Loading

SUMMARY

added a new feature flage

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

multi columns groupby

single column groupby

TEST PLAN

ADDITIONAL INFORMATION

codecov-io commented Feb 22, 2021 • edited by codecov bot Loading

Codecov Report

junlincc commented Feb 23, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhaoyongjie Feb 23, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhaoyongjie Feb 23, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

villebro Feb 24, 2021 • edited Loading

Choose a reason for hiding this comment

junlincc Feb 24, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

junlincc Feb 24, 2021 • edited Loading

Choose a reason for hiding this comment

ktmud Feb 24, 2021 • edited Loading

Choose a reason for hiding this comment

zhaoyongjie commented Feb 23, 2021

Choose a reason for hiding this comment

zhaoyongjie Feb 23, 2021 • edited Loading

Choose a reason for hiding this comment

villebro Feb 24, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

villebro left a comment

Choose a reason for hiding this comment

villebro Feb 24, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

villebro Feb 24, 2021 • edited Loading

Choose a reason for hiding this comment

villebro Feb 24, 2021 • edited Loading

Choose a reason for hiding this comment

ktmud Feb 24, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

junlincc commented Feb 24, 2021 • edited Loading

ktmud commented Feb 24, 2021 • edited Loading

villebro left a comment

Choose a reason for hiding this comment

ktmud left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

junlincc commented Feb 26, 2021

junlincc commented Feb 26, 2021

zhaoyongjie commented Feb 26, 2021

junlincc commented Mar 1, 2021 • edited Loading

zhaoyongjie commented Feb 18, 2021 •

edited

Loading

codecov-io commented Feb 22, 2021 •

edited by codecov bot

Loading

junlincc commented Feb 23, 2021 •

edited

Loading

zhaoyongjie Feb 23, 2021 •

edited

Loading

zhaoyongjie Feb 23, 2021 •

edited

Loading

villebro Feb 24, 2021 •

edited

Loading

junlincc Feb 24, 2021 •

edited

Loading

junlincc Feb 24, 2021 •

edited

Loading

ktmud Feb 24, 2021 •

edited

Loading

zhaoyongjie Feb 23, 2021 •

edited

Loading

villebro Feb 24, 2021 •

edited

Loading

villebro Feb 24, 2021 •

edited

Loading

villebro Feb 24, 2021 •

edited

Loading

villebro Feb 24, 2021 •

edited

Loading

ktmud Feb 24, 2021 •

edited

Loading

junlincc commented Feb 24, 2021 •

edited

Loading

ktmud commented Feb 24, 2021 •

edited

Loading

junlincc commented Mar 1, 2021 •

edited

Loading