Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat: add dropGroupByControl #967

Merged
merged 6 commits into from
Feb 26, 2021
Merged

feat: add dropGroupByControl #967

merged 6 commits into from
Feb 26, 2021

Conversation

zhaoyongjie
Copy link
Contributor

🏆 Enhancements
POC of Explore drag and drop query panel. scope - Groupby control only.
link to: apache/superset#13210

@vercel
Copy link

vercel bot commented Feb 19, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/CUpdoWamotF4VgVKhSpjApXuPSBR
✅ Preview: https://superset-ui-git-fork-zhaoyongjie-draftdropgroupbycont-2b5184.vercel.app

@ktmud
Copy link
Contributor

ktmud commented Feb 19, 2021 •
edited
Loading

How about we name this dndColumnSelectControl? It's a control for selecting columns with drag and drop. We have deprecated groupby in QueryContext, so it's better to be consistent in control naming, too.

@zhaoyongjie
Copy link
Contributor Author

How about we name this dndColumnSelectControl? It's a control for selecting columns with drag and drop. We have deprecated groupby in QueryContext, so it's better to be consistent in control naming, too.

All right. I will rename it.

@zhaoyongjie zhaoyongjie marked this pull request as ready for review February 22, 2021 12:40
@zhaoyongjie zhaoyongjie requested a review from a team as a code owner February 22, 2021 12:40
@codecov
Copy link

codecov bot commented Feb 22, 2021 •
edited
Loading

Codecov Report

Merging #967 (a04821c) into master (bd4d592) will increase coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #967      +/-   ##
==========================================
+ Coverage   28.04%   28.05%   +0.01%     
==========================================
  Files         408      409       +1     
  Lines        8345     8363      +18     
  Branches     1166     1173       +7     
==========================================
+ Hits         2340     2346       +6     
- Misses       5861     5868       +7     
- Partials      144      149       +5
Impacted Files Coverage Δ
...et-ui-chart-controls/src/shared-controls/index.tsx 42.55% <16.66%> (-1.77%) ⬇️
...chart-controls/src/shared-controls/dndControls.tsx 41.66% <41.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd4d592...a04821c. Read the comment docs.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Feb 24, 2021
@kgabryje kgabryje mentioned this pull request Feb 25, 2021
Merged
ktmud
ktmud approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zhaoyongjie zhaoyongjie merged commit cad9de3 into apache-superset:master Feb 26, 2021
NejcZdovc pushed a commit to blotoutio/superset-ui that referenced this pull request Apr 20, 2021
@zhaoyongjie @NejcZdovc
feat: add dropGroupByControl (apache-superset#967)
fc29812 
* feat: add dropGroupByControl

* control rename to DndColumnSelectControl

* add DND feature flag

* wip

* fix lint

* duplicate dnd control
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ktmud ktmud ktmud approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhaoyongjie @ktmud