fix: case expression should not have double quotes #12562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
force-pushed
the
fix_case_expression
branch
from
8f1c05d
to
8b7d696
Compare
ktmud
approved these changes
Jan 15, 2021
Codecov Report
@@ Coverage Diff @@
## master #12562 +/- ##
==========================================
- Coverage 66.75% 63.15% -3.60%
==========================================
Files 1015 486 -529
Lines 49625 29956 -19669
Branches 4839 0 -4839
==========================================
- Hits 33125 18918 -14207
+ Misses 16377 11038 -5339
+ Partials 123 0 -123
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
villebro
pushed a commit
that referenced
this pull request
Jan 16, 2021
etr2460
pushed a commit
that referenced
this pull request
Jan 25, 2021
* release: bump to 1.0.0 and CHANGELOG * fix(explore): long metric name display (#12387) * fix(explore): long metric name display * add tooltip to control * chore: Show datasets when search input is empty (#12391) * chore: Fix typo “Rest” to “Reset” (#12392) * chore: upgrade eslint, babel, and prettier (#12393) * feat(explore): add tooltip to timepicker label (#12401) * chore: change Datasource to Dataset in Explore ui (#12402) * chore(explore):change dataset to datasource in ui * modal * Add space * Changing it back🤦🏾♀️ * Chargeback * fix: Refresh Interval Modal dropdown (#12406) * fix(native-filters): incorrect queriesData state (#12409) * refactor: from superset.utils.core break down date_parser (#12408) * Fixes control panel fields styling (#12236) (#12326) * feat: Resizable dataset and controls panels on Explore view (#12411) * Implement resizable panels on explore view * Optimize chart rendering while resizing * Make dataset column narrower Co-authored-by: Evan Rusackas <[email protected]> * fix(dashboard): artefacts shown while drag and dropping deck.gl charts (#12418) * [12181] Fix artifacts while drag and dropping deck.gl charts. * Run prettier * bump superset-ui packages for rolling window change (#12426) * chore: bump superset-ui deckgl plugin (#12466) * fix: do not show vertical scrollbar for charts in dashboard (#12478) * fix: do not show vertical scrollbar for charts in dashboard * Proper fix for #11419 Co-authored-by: Jesse Yang <[email protected]> * fix(dashboard): use datasource id from slice metadata (#12483) * fix(timepicker): make pyparsing thread safe (#12489) * fix: make pyparsing thread safe * remove parenthesis for decorator * fix (SQL Lab): disappearing results on tab switch (#12472) * fix (SQL Lab): disappearing results on tab switch * Remove state * Fix test * fix: import ZIP files that have been modified (#12425) * fix: import ZIP files that have been modified * Add unit test * update changelog with rc2 entries * fix: impose dataset ownership check on old API (#12491) * fix: impose dataset ownership check on old API * update UPDATING.md * partially protect the old MVC also * prevent metric and column add and update * ci: remove refs/tags from docker tags on a release (#12518) * ci: remove refs/tags from docker tags on a release * wider head * fix: lowercase all columns in examples (#12530) * fix(explore): time table control panel (#12532) * fix(explore): Add Time section back to FilterBox (#12537) * Fixing Pinot queries for time granularities: WEEKS/MONTHS/QUARTERS/YEARS (#12536) * fix: Select options overflowing Save chart modal on Explore view (#12522) * Fix select options overflowing modal * fix unit test Co-authored-by: Ville Brofeldt <[email protected]> * Fix list filters vertical alignment (#12497) * feat(db-engine): Add support for Apache Solr (#12403) * [db engine] Add support for Apache Solr * Fixing typo * chore: rename docker image in build_docker_image.sh, docker-compose.yml and helm values.yaml (#12337) * add rc3 changelog entries * fix: Popover closes on change of dropdowns values (#12410) * fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN (#12555) * fix(viz): missing groupby and broken adhoc metrics for boxplot (#12556) * fix: height on grid results (#12558) * fix: case expression should not have double quotes (#12562) * Fix 500 error when loading dashboards with slice having deleted dataset (#12535) * add rc4 changelog entries * Fixed typo on line 348 * Added files Co-authored-by: Daniel Gaspar <[email protected]> Co-authored-by: Yongjie Zhao <[email protected]> Co-authored-by: Geido <[email protected]> Co-authored-by: Junlin Chen <[email protected]> Co-authored-by: Jesse Yang <[email protected]> Co-authored-by: Agata Stawarz <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]> Co-authored-by: Evan Rusackas <[email protected]> Co-authored-by: Kasia Kucharczyk <[email protected]> Co-authored-by: Phillip Kelley-Dotson <[email protected]> Co-authored-by: Grace Guo <[email protected]> Co-authored-by: Beto Dealmeida <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Xiang Fu <[email protected]> Co-authored-by: Ahmed Adel <[email protected]> Co-authored-by: Amit Miran <[email protected]> Co-authored-by: Hugh A. Miles II <[email protected]> Co-authored-by: Shuyao Bi <[email protected]> Co-authored-by: Lyndsi Kay Williams <[email protected]>
mistercrunch
added
🍒 1.0.0
🍒 1.0.1
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix
CASEexpression so it uses single quotes instead of double.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
In MySQL:
TEST PLAN
Tested in MySQL, Postgres and Sqlite (see screenshots for MySQL).
ADDITIONAL INFORMATION