Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explore): add tooltip to timepicker label #12401

Merged
merged 2 commits into from
Jan 11, 2021

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

The user should get both human readable text and actual datetime range, so Add tooltip to timepicker control pill

      HRT == human readable text
      ADR == actual datetime range
      +--------------+------+----------+--------+----------+-----------+
      |              | Last | Previous | Custom | Advanced | No Filter |
      +--------------+------+----------+--------+----------+-----------+
      | control pill | HRT  | HRT      | ADR    | ADR      |   ADR     |
      +--------------+------+----------+--------+----------+-----------+
      | tooltip      | ADR  | ADR      | HRT    | HRT      |   HRT     |
      +--------------+------+----------+--------+----------+-----------+

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

  1. last / previous frame
    image

  2. custom / Advanced / no filter frame
    image

TEST PLAN

tested in my local browser

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Jan 10, 2021

Codecov Report

Merging #12401 (63e27c6) into master (f13f2e2) will decrease coverage by 0.18%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12401      +/-   ##
==========================================
- Coverage   66.88%   66.69%   -0.19%     
==========================================
  Files        1014     1014              
  Lines       49528    49513      -15     
  Branches     5074     5077       +3     
==========================================
- Hits        33125    33023     -102     
- Misses      16273    16359      +86     
- Partials      130      131       +1     
Flag Coverage Δ
cypress 50.97% <82.35%> (+0.05%) ⬆️
javascript 60.71% <5.55%> (+0.01%) ⬆️
python 63.89% <ø> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/controls/DateFilterControl/DateFilterControl.tsx 85.45% <83.33%> (-0.40%) ⬇️
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/db_engine_specs/mysql.py 79.59% <0.00%> (-12.25%) ⬇️
superset/db_engine_specs/sqlite.py 65.62% <0.00%> (-9.38%) ⬇️
superset/databases/commands/create.py 83.67% <0.00%> (-8.17%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/databases/commands/test_connection.py 84.78% <0.00%> (-4.35%) ⬇️
superset/utils/celery.py 96.42% <0.00%> (-3.58%) ⬇️
...frontend/src/components/SupersetResourceSelect.tsx 75.86% <0.00%> (-3.45%) ⬇️
superset/models/core.py 85.86% <0.00%> (-2.99%) ⬇️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f13f2e2...63e27c6. Read the comment docs.

@junlincc junlincc added the explore:time Related to the time filters in Explore label Jan 10, 2021
Copy link
Member

@junlincc junlincc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2021-01-10 at 5 53 54 PM

Screen Shot 2021-01-10 at 5 53 31 PM

Screen Shot 2021-01-10 at 5 55 19 PM

sick🔥🔥🔥🔥🔥

Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit

@ktmud ktmud merged commit 23263da into apache:master Jan 11, 2021
@villebro villebro added the v1.0 label Jan 12, 2021
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Jan 14, 2021
@ktmud
Copy link
Member

ktmud commented Jan 14, 2021

@zhaoyongjie @junlincc should "No filter" also display as human readable text?

@zhaoyongjie
Copy link
Member Author

zhaoyongjie commented Jan 15, 2021 via email

@zhaoyongjie zhaoyongjie deleted the timepicker_tooltip branch January 16, 2021 04:17
etr2460 pushed a commit that referenced this pull request Jan 25, 2021
* release: bump to 1.0.0 and CHANGELOG

* fix(explore): long metric name display (#12387)

* fix(explore): long metric name display

* add tooltip to control

* chore: Show datasets when search input is empty (#12391)

* chore: Fix typo “Rest” to “Reset” (#12392)

* chore: upgrade eslint, babel, and prettier (#12393)

* feat(explore): add tooltip to timepicker label (#12401)

* chore: change Datasource to Dataset in Explore ui (#12402)

* chore(explore):change dataset to datasource in ui

* modal

* Add space

* Changing it back🤦🏾‍♀️

* Chargeback

* fix: Refresh Interval Modal dropdown (#12406)

* fix(native-filters): incorrect queriesData state (#12409)

* refactor: from superset.utils.core break down date_parser (#12408)

* Fixes control panel fields styling (#12236) (#12326)

* feat: Resizable dataset and controls panels on Explore view (#12411)

* Implement resizable panels on explore view

* Optimize chart rendering while resizing

* Make dataset column narrower

Co-authored-by: Evan Rusackas <[email protected]>

* fix(dashboard): artefacts shown while drag and dropping deck.gl charts (#12418)

* [12181] Fix artifacts while drag and dropping deck.gl charts.

* Run prettier

* bump superset-ui packages for rolling window change (#12426)

* chore: bump superset-ui deckgl plugin (#12466)

* fix: do not show vertical scrollbar for charts in dashboard (#12478)

* fix: do not show vertical scrollbar for charts in dashboard

* Proper fix for #11419

Co-authored-by: Jesse Yang <[email protected]>

* fix(dashboard): use datasource id from slice metadata (#12483)

* fix(timepicker): make pyparsing thread safe (#12489)

* fix: make pyparsing thread safe

* remove parenthesis for decorator

* fix (SQL Lab): disappearing results on tab switch (#12472)

* fix (SQL Lab): disappearing results on tab switch

* Remove state

* Fix test

* fix: import ZIP files that have been modified (#12425)

* fix: import ZIP files that have been modified

* Add unit test

* update changelog with rc2 entries

* fix: impose dataset ownership check on old API (#12491)

* fix: impose dataset ownership check on old API

* update UPDATING.md

* partially protect the old MVC also

* prevent metric and column add and update

* ci: remove refs/tags from docker tags on a release (#12518)

* ci: remove refs/tags from docker tags on a release

* wider head

* fix: lowercase all columns in examples (#12530)

* fix(explore): time table control panel (#12532)

* fix(explore): Add Time section back to FilterBox (#12537)

* Fixing Pinot queries for time granularities: WEEKS/MONTHS/QUARTERS/YEARS (#12536)

* fix: Select options overflowing Save chart modal on Explore view (#12522)

* Fix select options overflowing modal

* fix unit test

Co-authored-by: Ville Brofeldt <[email protected]>

* Fix list filters vertical alignment (#12497)

* feat(db-engine): Add support for Apache Solr (#12403)

* [db engine] Add support for Apache Solr

* Fixing typo

* chore: rename docker image in build_docker_image.sh, docker-compose.yml and helm values.yaml (#12337)

* add rc3 changelog entries

* fix: Popover closes on change of dropdowns values (#12410)

* fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN (#12555)

* fix(viz): missing groupby and broken adhoc metrics for boxplot (#12556)

* fix: height on grid results (#12558)

* fix: case expression should not have double quotes (#12562)

* Fix 500 error when loading dashboards with slice having deleted dataset (#12535)

* add rc4 changelog entries

* Fixed typo on line 348

* Added files

Co-authored-by: Daniel Gaspar <[email protected]>
Co-authored-by: Yongjie Zhao <[email protected]>
Co-authored-by: Geido <[email protected]>
Co-authored-by: Junlin Chen <[email protected]>
Co-authored-by: Jesse Yang <[email protected]>
Co-authored-by: Agata Stawarz <[email protected]>
Co-authored-by: Ville Brofeldt <[email protected]>
Co-authored-by: Michael S. Molina <[email protected]>
Co-authored-by: Kamil Gabryjelski <[email protected]>
Co-authored-by: Evan Rusackas <[email protected]>
Co-authored-by: Kasia Kucharczyk <[email protected]>
Co-authored-by: Phillip Kelley-Dotson <[email protected]>
Co-authored-by: Grace Guo <[email protected]>
Co-authored-by: Beto Dealmeida <[email protected]>
Co-authored-by: Ville Brofeldt <[email protected]>
Co-authored-by: Xiang Fu <[email protected]>
Co-authored-by: Ahmed Adel <[email protected]>
Co-authored-by: Amit Miran <[email protected]>
Co-authored-by: Hugh A. Miles II <[email protected]>
Co-authored-by: Shuyao Bi <[email protected]>
Co-authored-by: Lyndsi Kay Williams <[email protected]>
@mistercrunch mistercrunch added 🍒 1.0.0 🍒 1.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels explore:time Related to the time filters in Explore size/M v1.0 🍒 1.0.0 🍒 1.0.1 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants