fix: Issues with filters and metrics popovers #11578
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11578 +/- ##
==========================================
- Coverage 59.59% 54.96% -4.64%
==========================================
Files 832 412 -420
Lines 40482 14281 -26201
Branches 3666 3662 -4
==========================================
- Hits 24126 7849 -16277
+ Misses 16187 6263 -9924
Partials 169 169
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Fixes #11546 |
| @@ -50,7 +50,11 @@ const defaultProps = { | |||
| columns: [], | |||
| }; | |||
|
|
|||
| const startingWidth = 300; | |||
| const ResizeIcon = styled.i` | |||
There was a problem hiding this comment.
I see this is happening a couple times in this PR, but I can't think of an easy way to DRY this up that would be worth doing if we come through and start replacing all the font-awesome icons in another pass anyway. Only mentioning it in case you have an idea of how to simply consolidate the two ResizeIcon instances... but it's probably not worth worrying about. So now I'm just rambling...
There was a problem hiding this comment.
I felt bad when repeating that code, but I couldn't see an easy way not to 🙁 In general, I think it might be worth it to refactor Metric and Filter popovers, because they are rather similar, with only tabs content differing.
|
created new issue.. #11598 |
* Fix bugs in AdhocFilterEditPopover * Fix bugs in AdhocMetricEditPopover * Remove handleMultiComparatorInputHeightChange function * Fix tests
mistercrunch
added
🏷️ bot
SUMMARY
Fixes issues described in #11546.
There was also another bug - select menu wasn't fully visible when it overflew the popover (which is almost always) - see the first gif.
The filters popover was jumpy and it was related to
handleMultiComparatorInputHeightChangefunction inAdhocFilterEditPopoverSimpleTabContent.jsxfile. I removed it, however if it was actually necessary for something I'd appreciate a feedback (@ktmud the last changes to that function was done by you - can you take a look?).BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
ADDITIONAL INFORMATION