Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Explore]multiple cosmetic issues in Explore popover (metrics, filters) #11546

Closed
junlincc opened this issue Nov 4, 2020 · 6 comments
Closed
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed !deprecated-label:bug Deprecated label - Use #bug instead

Comments

@junlincc
Copy link
Member

junlincc commented Nov 4, 2020

ezgif-7-88e7dc0f4ce5

  1. Text area and buttons overlap
    Text area should have a smaller fixed height, scroll bar should stay within the text area

  2. Save and Close button
    Save should be on the right, Close on the left

  3. Resize icon
    shrink icon and enough spacing between icon and button

@junlincc junlincc added the #bug:cosmetic Cosmetic/layout/design tweak needed label Nov 4, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.82. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the !deprecated-label:bug Deprecated label - Use #bug instead label Nov 4, 2020
@junlincc
Copy link
Member Author

junlincc commented Nov 4, 2020

@kgabryje 🙏

@junlincc junlincc changed the title multiple cosmetic issues in Explore metrics popover multiple cosmetic issues in Explore popover (metrics, filters) Nov 4, 2020
@junlincc junlincc changed the title multiple cosmetic issues in Explore popover (metrics, filters) [Explore]multiple cosmetic issues in Explore popover (metrics, filters) Nov 4, 2020
@rusackas
Copy link
Member

rusackas commented Nov 6, 2020

@junlin I think we're good here, but I'll let you verify on master :)

Also surprised GH doesn't automatically close issues when the PR says "Fixes #xyz"

@nytai
Copy link
Member

nytai commented Nov 6, 2020

@rusackas The fixes syntax works only when it's in the title, commit message, or description. You can also link the issue with the little widget on the right.

https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue

@rusackas
Copy link
Member

rusackas commented Nov 6, 2020

I did it in the description not long ago and it didn't seem to work there. I've never tried the manual linking widget... will do next time for fun :D

@junlincc
Copy link
Member Author

junlincc commented Nov 9, 2020

all looking good! we can finally move on from popover!! 😆

@junlincc junlincc closed this as completed Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed !deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Development

No branches or pull requests

3 participants