Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: globally disable underscore for links in menu items #11491

Merged
merged 1 commit into from
Nov 2, 2020
Merged

feat: globally disable underscore for links in menu items #11491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 25 additions & 4 deletions superset-frontend/src/common/components/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,37 @@
* under the License.
*/
import { styled } from '@superset-ui/core';
import { Skeleton } from 'antd';
// eslint-disable-next-line no-restricted-imports
import { Skeleton, Menu as AntdMenu } from 'antd';

/*
Antd is exported from here so we can override components with Emotion as needed.
Antd is re-exported from here so we can override components with Emotion as needed.

For documentation, see https://ant.design/components/overview/
*/
/* eslint no-restricted-imports: 0 */
// eslint-disable-next-line no-restricted-imports
export {
Avatar,
Card,
Collapse,
Empty,
Dropdown,
Modal,
Popover,
Skeleton,
Tabs,
Tooltip,
} from 'antd';

export * from 'antd';
export const MenuItem = styled(AntdMenu.Item)`
> a {
text-decoration: none;
}
`;

export const Menu = Object.assign(AntdMenu, {
Item: MenuItem,
});

export const ThinSkeleton = styled(Skeleton)`
h3 {
Expand Down