feat: globally disable underscore for links in menu items #11491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @kgabryje |
Codecov Report
@@ Coverage Diff @@
## master #11491 +/- ##
==========================================
- Coverage 66.54% 62.29% -4.25%
==========================================
Files 873 873
Lines 41767 41762 -5
Branches 3826 3826
==========================================
- Hits 27792 26017 -1775
- Misses 13873 15566 +1693
- Partials 102 179 +77
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rusackas
reviewed
Oct 29, 2020
6 tasks
ktmud
force-pushed
the
menu-item-anchor
branch
from
6db7ca6 to
ce4f3d6
Compare
ktmud
force-pushed
the
menu-item-anchor
branch
from
ce4f3d6 to
7bcd436
Compare
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Globally disable underscore for links in menu items. Adding style overrides with styled components.
Developers should now use
import { MenuItem } from "src/common/components", instead ofMenu.Item.Also makes antd exports explicit so that it's easier to override components under the same name.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
#11395 (comment)
After
TEST PLAN
Manual
ADDITIONAL INFORMATION