fix: timer component, fixes #10849, closes #11002 #11004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
6 tasks
nytai
approved these changes
Sep 22, 2020
ktmud
force-pushed
the
bugfix--timer
branch
from
3e485e8 to
276b931
Compare
|
Thanks for the quick fix! i tested locally and it is working good. I will close the revert PR and favor this ! |
|
Yay thanks @ktmud |
|
@nytai @graceguo-supercat Just did a little more refactoring and added a Cypress test for this bug. I also tested it with the buggy |
Codecov Report
@@ Coverage Diff @@
## master #11004 +/- ##
==========================================
- Coverage 65.81% 61.22% -4.59%
==========================================
Files 816 816
Lines 38381 38374 -7
Branches 3606 3606
==========================================
- Hits 25260 23495 -1765
- Misses 13013 14693 +1680
- Partials 108 186 +78
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
looks even better to me! 😄 |
ktmud
force-pushed
the
bugfix--timer
branch
2 times, most recently
from
f512145 to
b07d11c
Compare
|
The Cypress test keeps failing in CI. Skip it for now to unblock merging. |
ktmud
force-pushed
the
bugfix--timer
branch
from
28a8cfb to
63378d4
Compare
rorymillersoft
referenced
this pull request
in nets-aric/incubator-superset
Oct 16, 2020
* master: (466 commits) chore: bump pandas to latest stable version (#11018) fix: dashboard edit button (again) (#11029) style(explore): use tertiary button against gray background (#11011) docs: add security vulnerability GH issue template (#11023) fix: [dashboard] should not show edit button when user has no edit permit (#11024) fix: timer component, fixes #10849, closes #11002 (#11004) fix: enable several pylint rules partially in db_engines_specs module (#11000) fix: pylint checks in connectors/sqla/models.py (#10974) fix: reenable pylint rule `unused-import` in charts and connectors modules (#11014) Enabled pylint rules in `db_engines` module: (#11016) fix: changes a pylint check in dashboard module (#10978) fix: menu shows a 0 when there are not settings (#11009) fix: query search low privileged user search access denied (#11017) chore: downgrade expected exception from error to info (#10994) fix: Add Item Overflow on Dataset Editor (#10983) Bring back import menu (#11007) feat(listview): feature flag config to set default viewing mode (#10986) build: add react-hooks linting (#11006) fix: unbreak ci (#11003) fix: enable pylint rules in db_engine_specs module (#10998) ... # Conflicts: # requirements.txt # superset/app.py # superset/models/schedules.py # superset/tasks/schedules.py # superset/translations/messages.pot
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
the
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #10849 introduced by #10455 . Closes #11002 .
I did testing locally. Will add some integration tests shortly.
cc @nytai @graceguo-supercat @etr2460 @tanmaylaud
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION