Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timer in SQL Lab and Explore doesn't work #10849

Closed
2 of 3 tasks
zuzana-vej opened this issue Sep 12, 2020 · 12 comments · Fixed by #11004
Closed
2 of 3 tasks

Timer in SQL Lab and Explore doesn't work #10849

zuzana-vej opened this issue Sep 12, 2020 · 12 comments · Fixed by #11004
Labels
!deprecated-label:bug Deprecated label - Use #bug instead

Comments

@zuzana-vej
Copy link
Contributor

A clear and concise description of what the bug is.
The timer in SQL Lab doesn't work. When you run the query 1st time, it shows some number (unsure if accurate). When you run a query 2nd time the value on the timer doesn't change.

Expected results

The timer should reset every time user hits the "RUN" button, and start counting again from 0.

Actual results

Timer is stuck.

Screenshots

Step 1: Running 1st query: (timer has some result, which looks inacurate, the query took longer than 0.67 sec
sqllab-timer-bug
Timer detail:
Screen Shot 2020-09-11 at 5 55 40 PM

Step 2: Change to different SQL Lab tab and run 2nd query:
step1
Timer detail:
Screen Shot 2020-09-11 at 5 56 02 PM

See query is running - timer value doesn't change
step2
Timer detail:
Screen Shot 2020-09-11 at 5 56 08 PM

Query finished and returned result - timer is still displaying same value as before hitting RUN button:
steap3
Timer detail:
Screen Shot 2020-09-11 at 5 56 13 PM

How to reproduce the bug

  1. Go to SQL Lab
  2. Click on RUN query
  3. See the timer and whether it changes
  4. Run query again, see the timer and whether it changes

Environment

  • superset version: latest

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@zuzana-vej zuzana-vej added the !deprecated-label:bug Deprecated label - Use #bug instead label Sep 12, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.98. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@junlincc
Copy link
Member

thanks for reporting the timer issue.

@john-bodley
Copy link
Member

Note I believe the timer is also broken in explorer as well.

@zuzana-vej
Copy link
Contributor Author

Yes, correct, it happens on Explore as well. Here is an example:

  1. Clicked to refresh the chart (which was previous cached). While query is running, it displayed this timer: (even right after click it says 5s)

Screen Shot 2020-09-15 at 12 22 38 PM

2. Once query finished, timer looks like this (query took longer than 5 seconds):

Screen Shot 2020-09-15 at 12 22 48 PM

@zuzana-vej zuzana-vej changed the title Timer in SQL Lab doesn't work Timer in SQL Lab and Explore doesn't work Sep 15, 2020
@junlincc
Copy link
Member

@tanmaylaud @rusackas

@tanmaylaud
Copy link
Contributor

@junlinc @rusackas I haven't been able to reproduce this issue locally. The master branch seems to be working fine.
Here's a video of me running the queries: https://www.youtube.com/watch?v=RTr0lXGjrO0

@junlincc
Copy link
Member

junlincc commented Sep 19, 2020 via email

@zuzana-vej
Copy link
Contributor Author

@tanmaylaud can you confirm which version you see this is working as expected? (the latest superset release or master ( and master as of which day))? Everyone from our team sees the same issue. Is it possible that it was fixed recently (within last few days)? I shared couple videos with Junlin directly, she can share the folder with you.

@graceguo-supercat
Copy link

graceguo-supercat commented Sep 22, 2020 •
edited
Loading

@tanmaylaud please run a longer query in SQL lab. in your example, query is too short that you can't tell if Timer display a correct running time.
Run a query like select * from wb_health_population limit = 500.
This is what i experienced: Note i clicked run button twice, the timer didn't even reset to 0
LwMnIK6BxF

@zuzana-vej
Copy link
Contributor Author

We believe the issue is with this PR a6fa02a (reverting it locally fixes the timer issue locally). I can slack you link to the video recording.

@mistercrunch
Copy link
Member

revert?

@graceguo-supercat graceguo-supercat mentioned this issue Sep 22, 2020
Closed
6 tasks
@ktmud ktmud mentioned this issue Sep 22, 2020
Merged
6 tasks
@nytai nytai linked a pull request Sep 22, 2020 that will close this issue
fix: timer component, fixes #10849, closes #11002 #11004
Merged
6 tasks
@junlincc
Copy link
Member

thanks @ktmud for fixing!

ktmud added a commit to ktmud/superset that referenced this issue Sep 23, 2020
@ktmud
fix: timer component, fixes apache#10849, closes apache#11002
efa13b2
ktmud added a commit that referenced this issue Sep 23, 2020
@ktmud
fix: timer component, fixes #10849, closes #11002 (#11004)
7549dad
rorymillersoft referenced this issue in nets-aric/incubator-superset Oct 16, 2020
@rorymillersoft
Merge branch 'master' into superset_additions
320ab1e 
* master: (466 commits)
  chore: bump pandas to latest stable version (#11018)
  fix: dashboard edit button (again) (#11029)
  style(explore): use tertiary button against gray background (#11011)
  docs: add security vulnerability GH issue template (#11023)
  fix: [dashboard] should not show edit button when user has no edit permit (#11024)
  fix: timer component, fixes #10849, closes #11002 (#11004)
  fix: enable several pylint rules partially in db_engines_specs module (#11000)
  fix: pylint checks in connectors/sqla/models.py (#10974)
  fix: reenable pylint rule `unused-import` in charts and connectors modules (#11014)
  Enabled pylint rules in `db_engines` module: (#11016)
  fix: changes a pylint check in dashboard module (#10978)
  fix: menu shows a 0 when there are not settings (#11009)
  fix: query search low privileged user search access denied (#11017)
  chore: downgrade expected exception from error to info (#10994)
  fix: Add Item Overflow on Dataset Editor (#10983)
  Bring back import menu (#11007)
  feat(listview): feature flag config to set default viewing mode (#10986)
  build: add react-hooks linting (#11006)
  fix: unbreak ci (#11003)
  fix: enable pylint rules in db_engine_specs module (#10998)
  ...

# Conflicts:
#	requirements.txt
#	superset/app.py
#	superset/models/schedules.py
#	superset/tasks/schedules.py
#	superset/translations/messages.pot
auxten pushed a commit to auxten/incubator-superset that referenced this issue Nov 20, 2020
@ktmud @auxten
fix: timer component, fixes apache#10849, closes apache#11002 (apache…
1c9cc28 
…#11004)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
!deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: timer component, fixes #10849, closes #11002 ktmud/superset
6 participants
@mistercrunch @john-bodley @graceguo-supercat @tanmaylaud @zuzana-vej @junlincc