Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqllab): log exceptions caused by the user as debug and not error #10676

Merged
merged 1 commit into from
Aug 25, 2020
Merged

fix(sqllab): log exceptions caused by the user as debug and not error #10676

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion superset/sql_lab.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,6 @@ def get_sql_results( # pylint: disable=too-many-arguments
log_params=log_params,
)
except Exception as ex: # pylint: disable=broad-except
logger.error("Query %d", query_id)
Copy link
Member Author

@nytai nytai Aug 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem very useful, all that ends up being logged is something like

Query 694: <class 'pymssql.ProgrammingError'>

Which is very noisy and not very useful from a developer perspective.

logger.debug("Query %d: %s", query_id, ex)
stats_logger.incr("error_sqllab_unhandled")
query = get_query(query_id, session)
Expand Down