-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sqllab): log exceptions caused by the user as debug and not error #10676
Conversation
a9fe656
to
a067b51
Compare
@@ -183,7 +183,6 @@ def get_sql_results( # pylint: disable=too-many-arguments | |||
log_params=log_params, | |||
) | |||
except Exception as ex: # pylint: disable=broad-except | |||
logger.error("Query %d", query_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem very useful, all that ends up being logged is something like
Query 694: <class 'pymssql.ProgrammingError'>
Which is very noisy and not very useful from a developer perspective.
Codecov Report
@@ Coverage Diff @@
## master #10676 +/- ##
==========================================
+ Coverage 64.36% 64.41% +0.04%
==========================================
Files 785 785
Lines 36981 36980 -1
Branches 3530 3530
==========================================
+ Hits 23803 23819 +16
+ Misses 13070 13052 -18
- Partials 108 109 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
CI passes
ADDITIONAL INFORMATION