Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: FilterSelect style tweaks #10446

Merged
merged 4 commits into from
Jul 29, 2020
Merged

style: FilterSelect style tweaks #10446

merged 4 commits into from
Jul 29, 2020

Conversation

mistercrunch
Copy link
Member

After

Screen Shot 2020-07-27 at 8 33 38 PM

Before

Screen Shot 2020-07-27 at 8 35 18 PM

@rusackas
Copy link
Member

Added a couple suggestions using the theme variables instead of the hard-coded 12px. Otherwise, simple enough :) 👍

@mistercrunch mistercrunch changed the title style: FilterSelect style tweaks styles: FilterSelect style tweaks Jul 28, 2020
@mistercrunch mistercrunch changed the title styles: FilterSelect style tweaks FilterSelect style tweaks Jul 28, 2020
@mistercrunch mistercrunch changed the title FilterSelect style tweaks style: FilterSelect style tweaks Jul 28, 2020
@rusackas
Copy link
Member

Added some suggestions in a branch off of your branch., and opened a PR on the fork for your consideration.

@mistercrunch
Merge pull request #24 from preset-io/filterselect-styles-withTheme
364e17b 
using withTheme to avoid raw supersetTheme
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2020 •
edited
Loading

Codecov Report

Merging #10446 into master will increase coverage by 0.80%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10446      +/-   ##
==========================================
+ Coverage   70.25%   71.06%   +0.80%     
==========================================
  Files         605      610       +5     
  Lines       32377    34209    +1832     
  Branches     3271     3356      +85     
==========================================
+ Hits        22745    24309    +1564     
- Misses       9522     9786     +264     
- Partials      110      114       +4
Flag Coverage Δ
#cypress 54.02% <ø> (-0.56%) ⬇️
#javascript 59.60% <100.00%> (+0.52%) ⬆️
#python 71.31% <ø> (+1.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erset-frontend/src/components/ListView/Filters.tsx 72.72% <100.00%> (+0.85%) ⬆️
...perset-frontend/src/datasource/DatasourceModal.jsx 56.41% <0.00%> (-20.52%) ⬇️
...et-frontend/src/SqlLab/reducers/getInitialState.js 33.33% <0.00%> (-16.67%) ⬇️
...perset-frontend/src/messageToasts/actions/index.js 91.66% <0.00%> (-8.34%) ⬇️
...rontend/src/SqlLab/components/TabbedSqlEditors.jsx 77.27% <0.00%> (-5.20%) ⬇️
...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx 44.00% <0.00%> (-4.00%) ⬇️
...et-frontend/src/messageToasts/components/Toast.tsx 96.96% <0.00%> (-3.04%) ⬇️
...end/src/SqlLab/components/TemplateParamsEditor.jsx 88.57% <0.00%> (-2.86%) ⬇️
superset-frontend/src/SqlLab/actions/sqlLab.js 60.25% <0.00%> (-2.36%) ⬇️
superset-frontend/src/SqlLab/reducers/sqlLab.js 37.75% <0.00%> (-1.66%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f56cd5...05927e6. Read the comment docs.

@rusackas
Copy link
Member

shakes fist at Cypress CI process

@rusackas rusackas self-requested a review July 29, 2020 23:54
@mistercrunch mistercrunch merged commit e6e6b49 into apache:master Jul 29, 2020
@rusackas
Copy link
Member

Impacts #8976

auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch @rusackas @auxten
style: FilterSelect style tweaks (apache#10446)
da93f6f 
* style: FilterSelect style tweaks

* using withTheme to avoid raw supersetTheme

* lint

Co-authored-by: Evan Rusackas <[email protected]>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

@nytai nytai Awaiting requested review from nytai

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.38.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mistercrunch @rusackas @codecov-commenter