Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using withTheme to avoid raw supersetTheme #24

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

rusackas
Copy link
Member

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2020

Codecov Report

Merging #24 into filterselect-styles will decrease coverage by 6.13%.
The diff coverage is n/a.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           filterselect-styles      #24      +/-   ##
=======================================================
- Coverage                70.33%   64.19%   -6.14%     
=======================================================
  Files                      605      544      -61     
  Lines                    32378    30580    -1798     
  Branches                  3271     2885     -386     
=======================================================
- Hits                     22772    19631    -3141     
- Misses                    9499    10768    +1269     
- Partials                   107      181      +74     
Flag Coverage Δ
#cypress 54.88% <ø> (+0.03%) ⬆️
#javascript ?
#python 69.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
...uperset-frontend/src/views/CRUD/dataset/Button.tsx 6.66% <0.00%> (-93.34%) ⬇️
...uperset-frontend/src/utils/getClientErrorObject.ts 0.00% <0.00%> (-88.89%) ⬇️
.../src/dashboard/components/FilterIndicatorGroup.jsx 11.76% <0.00%> (-88.24%) ⬇️
...c/explore/components/controls/withVerification.jsx 9.09% <0.00%> (-87.88%) ⬇️
...src/dashboard/components/gridComponents/Header.jsx 10.52% <0.00%> (-86.85%) ⬇️
...rc/dashboard/components/gridComponents/Divider.jsx 13.33% <0.00%> (-86.67%) ⬇️
...c/dashboard/components/gridComponents/Markdown.jsx 6.59% <0.00%> (-82.42%) ⬇️
... and 220 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 430f34c...f9332f8. Read the comment docs.

@mistercrunch mistercrunch merged commit 364e17b into filterselect-styles Jul 29, 2020
preset-machine pushed a commit that referenced this pull request Nov 30, 2021
* fix: docs updated with queriesData

* chore: package linting

* fix: restoring missing controls

* feat: sections.legacyRegularTime
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants