Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-44619][INFRA][3.5] Free up disk space for container jobs #43381

Closed
wants to merge 1 commit into from

Conversation

LuciferYang
Copy link
Contributor

What changes were proposed in this pull request?

Free up disk space for container jobs

Why are the changes needed?

increase the available disk space

before this PR
image

after this PR
image

Does this PR introduce any user-facing change?

No, infra-only

How was this patch tested?

updated CI

Was this patch authored or co-authored using generative AI tooling?

No

### What changes were proposed in this pull request?
Free up disk space for container jobs

### Why are the changes needed?
increase the available disk space

before this PR
![image](https://github.com/apache/spark/assets/7322292/64230324-607b-4c1d-ac2d-84b9bcaab12a)

after this PR
![image](https://github.com/apache/spark/assets/7322292/aafed2d6-5d26-4f7f-b020-1efe4f551a8f)

### Does this PR introduce _any_ user-facing change?
No, infra-only

### How was this patch tested?
updated CI

Closes apache#42253 from zhengruifeng/infra_clean_container.

Authored-by: Ruifeng Zheng <[email protected]>
Signed-off-by: Ruifeng Zheng <[email protected]>
@@ -407,6 +407,8 @@ jobs:
key: pyspark-coursier-${{ hashFiles('**/pom.xml', '**/plugins.sbt') }}
restore-keys: |
pyspark-coursier-
- name: Free up disk space
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we add a condition?

        if [ -f ./dev/free_disk_space_container ]; then
          ./dev/free_disk_space_container
        fi

since this might be also used in 3.4?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm, I am confused now. ignore ^^^ if it doesn't break anything.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's unnecessary, this yml file won't be used by other branches.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current build_and_test.yml is for individual branch (when a commit is arrived, and the job is triggered).

The confusion is from the fact that we share the same build_and_test.yml in the master branch for scheduled jobs in other branches (e.g., https://github.com/apache/spark/actions/workflows/build_branch34.yml).

Scheduled jobs use the one in the master branch.

@LuciferYang
Copy link
Contributor Author

https://github.com/apache/spark/actions/runs/6510937376
found No space left on device log on branch-3.5 ci:

image image

@LuciferYang
Copy link
Contributor Author

LuciferYang commented Oct 16, 2023

LuciferYang pushed a commit that referenced this pull request Oct 16, 2023
### What changes were proposed in this pull request?
Free up disk space for container jobs

### Why are the changes needed?
increase the available disk space

before this PR
![image](https://github.com/apache/spark/assets/7322292/64230324-607b-4c1d-ac2d-84b9bcaab12a)

after this PR
![image](https://github.com/apache/spark/assets/7322292/aafed2d6-5d26-4f7f-b020-1efe4f551a8f)

### Does this PR introduce _any_ user-facing change?
No, infra-only

### How was this patch tested?
updated CI

### Was this patch authored or co-authored using generative AI tooling?
No

Closes #43381 from LuciferYang/SPARK-44619-35.

Authored-by: Ruifeng Zheng <[email protected]>
Signed-off-by: yangjie01 <[email protected]>
@LuciferYang
Copy link
Contributor Author

Merged into branch-3.5. Thanks @zhengruifeng @LuciferYang @yaooqinn @beliefer

@beliefer
Copy link
Contributor

@LuciferYang Thank you. I retriggered GA for #43330

@LuciferYang LuciferYang deleted the SPARK-44619-35 branch October 18, 2023 05:24
zhengruifeng pushed a commit that referenced this pull request Jul 9, 2024
…ee_disk_space_container`

### What changes were proposed in this pull request?
This PR removed the check for the existence of `./dev/free_disk_space_container` before execution,  because `./dev/free_disk_space_container` has already been backported to branch-3.4 and branch-3.5 through #45624 and #43381,  so there is no need to check its existence before execution.

### Why are the changes needed?
Remove unnecessary existence check for `./dev/free_disk_space_container`.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Pass GitHub Actions

### Was this patch authored or co-authored using generative AI tooling?
No

Closes #47263 from LuciferYang/SPARK-48840.

Authored-by: yangjie01 <[email protected]>
Signed-off-by: Ruifeng Zheng <[email protected]>
ericm-db pushed a commit to ericm-db/spark that referenced this pull request Jul 10, 2024
…ee_disk_space_container`

### What changes were proposed in this pull request?
This PR removed the check for the existence of `./dev/free_disk_space_container` before execution,  because `./dev/free_disk_space_container` has already been backported to branch-3.4 and branch-3.5 through apache#45624 and apache#43381,  so there is no need to check its existence before execution.

### Why are the changes needed?
Remove unnecessary existence check for `./dev/free_disk_space_container`.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Pass GitHub Actions

### Was this patch authored or co-authored using generative AI tooling?
No

Closes apache#47263 from LuciferYang/SPARK-48840.

Authored-by: yangjie01 <[email protected]>
Signed-off-by: Ruifeng Zheng <[email protected]>
jingz-db pushed a commit to jingz-db/spark that referenced this pull request Jul 22, 2024
…ee_disk_space_container`

### What changes were proposed in this pull request?
This PR removed the check for the existence of `./dev/free_disk_space_container` before execution,  because `./dev/free_disk_space_container` has already been backported to branch-3.4 and branch-3.5 through apache#45624 and apache#43381,  so there is no need to check its existence before execution.

### Why are the changes needed?
Remove unnecessary existence check for `./dev/free_disk_space_container`.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Pass GitHub Actions

### Was this patch authored or co-authored using generative AI tooling?
No

Closes apache#47263 from LuciferYang/SPARK-48840.

Authored-by: yangjie01 <[email protected]>
Signed-off-by: Ruifeng Zheng <[email protected]>
attilapiros pushed a commit to attilapiros/spark that referenced this pull request Oct 4, 2024
…ee_disk_space_container`

### What changes were proposed in this pull request?
This PR removed the check for the existence of `./dev/free_disk_space_container` before execution,  because `./dev/free_disk_space_container` has already been backported to branch-3.4 and branch-3.5 through apache#45624 and apache#43381,  so there is no need to check its existence before execution.

### Why are the changes needed?
Remove unnecessary existence check for `./dev/free_disk_space_container`.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Pass GitHub Actions

### Was this patch authored or co-authored using generative AI tooling?
No

Closes apache#47263 from LuciferYang/SPARK-48840.

Authored-by: yangjie01 <[email protected]>
Signed-off-by: Ruifeng Zheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants