-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-43990][BUILD] Upgrade kubernetes-client
to 6.7.2
#41490
Conversation
kubernetes-client
to 6.7.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that this is 5th commit for this dependency. It looks like we will have 6.7.2 in a month. Maybe, shall we hold on until July 1st if there is no urgency with those two bugs, @bjornjorgensen ?
$ git log --oneline --since 2023-05-01 | grep kubernetes-client
592857945c [SPARK-43950][BUILD] Upgrade `kubernetes-client` to 6.7.0
c87061fbcb [SPARK-43581][BUILD][K8S] Upgrade `kubernetes-client` to 6.6.2
2bcfebf8a9 [SPARK-43455][BUILD][K8S] Bump kubernetes-client 6.6.1
b550f2b1f4 [SPARK-43355][K8S][BUILD] Upgrade `kubernetes-client` to 6.6.0
You know, I'm also an active user for this library and eager to be up-to-date in master branch in general. |
yes, I know the reason for this is that SNYK are sending me mail about SNYK-JAVA-COMSQUAREUPOKHTTP3-2958044 |
Could you explain a little more which commit fixes that? I don't see any vulnerability fix here. |
hmm.. you are right about that they are on 3.12.1 |
It's because our feature freeze is July 16th and I believe you want to have up-to-date https://spark.apache.org/versioning-policy.html Of course, we can wait until July 15th, but then there is not enough time to test in the community. I assume |
ok, should I close this or let it open for some days or how will you have it? |
No~ Let's keep it open to reserve your contribution. You can update this PR later by adding a commit with new K8s client version (at that time). |
To the reviewer, v6.7.2 was released additionally. |
kubernetes-client
to 6.7.1kubernetes-client
to 6.7.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. The python linter failure is flaky one. Thank you for waiting and updating, @bjornjorgensen .
Since they usually don't release x.y.3, I believe we can merge this for Apache Spark 3.5.0.
### _Why are the changes needed?_ Now the kubernetes client version in apache/spark is 6.7.2(apache/spark#41490), I think it is better to align with that. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request Closes #5059 from turboFei/k8s_client_version. Closes #5059 79955d1 [fwang12] deps 4a68cc8 [fwang12] bump Authored-by: fwang12 <fwang12@ebay.com> Signed-off-by: Cheng Pan <chengpan@apache.org>
### _Why are the changes needed?_ Now the kubernetes client version in apache/spark is 6.7.2(apache/spark#41490), I think it is better to align with that. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request Closes apache#5059 from turboFei/k8s_client_version. Closes apache#5059 79955d1 [fwang12] deps 4a68cc8 [fwang12] bump Authored-by: fwang12 <fwang12@ebay.com> Signed-off-by: Cheng Pan <chengpan@apache.org>
Upgrade kubernetes-client from 6.7.0 to 6.7.2 [Release notes 6.7.1](https://github.com/fabric8io/kubernetes-client/releases/tag/v6.7.1) [Release notes 6.7.2](https://github.com/fabric8io/kubernetes-client/releases/tag/v6.7.2) No. Pass GA Closes apache#41490 from bjornjorgensen/k8s6.7.1. Authored-by: Bjørn Jørgensen <bjornjorgensen@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
What changes were proposed in this pull request?
Upgrade kubernetes-client from 6.7.0 to 6.7.2
Why are the changes needed?
Release notes 6.7.1
Release notes 6.7.2
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA