[BUILD] Upgrade kubernetes client version to 6.7.2 #5059
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
approved these changes
Jul 17, 2023
turboFei
commented
Jul 17, 2023
| @@ -181,6 +182,7 @@ simpleclient_tracer_common/0.16.0//simpleclient_tracer_common-0.16.0.jar | |||
| simpleclient_tracer_otel/0.16.0//simpleclient_tracer_otel-0.16.0.jar | |||
| simpleclient_tracer_otel_agent/0.16.0//simpleclient_tracer_otel_agent-0.16.0.jar | |||
| slf4j-api/1.7.36//slf4j-api-1.7.36.jar | |||
| snakeyaml-engine/2.6//snakeyaml-engine-2.6.jar | |||
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## master #5059 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 563 563
Lines 31218 31258 +40
Branches 4078 4091 +13
======================================
- Misses 31218 31258 +40 see 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks, merged to master |
link3280
pushed a commit
to link3280/kyuubi
that referenced
this pull request
Jul 23, 2023
### _Why are the changes needed?_ Now the kubernetes client version in apache/spark is 6.7.2(apache/spark#41490), I think it is better to align with that. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request Closes apache#5059 from turboFei/k8s_client_version. Closes apache#5059 79955d1 [fwang12] deps 4a68cc8 [fwang12] bump Authored-by: fwang12 <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Now the kubernetes client version in apache/spark is 6.7.2(apache/spark#41490), I think it is better to align with that.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request