Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor][Core] Cleanup unused vals in DAGScheduler.handleTaskCompletion #21406

Closed
wants to merge 1 commit into from

Conversation

jiangxb1987
Copy link
Contributor

What changes were proposed in this pull request?

Cleanup unused vals in DAGScheduler.handleTaskCompletion to reduce the code complexity slightly.

How was this patch tested?

Existing test cases.

@jiangxb1987
Copy link
Contributor Author

cc @cloud-fan

@SparkQA
Copy link

SparkQA commented May 23, 2018

Test build #91023 has finished for PR 21406 at commit 567a7ff.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

retest this please

@SparkQA
Copy link

SparkQA commented May 23, 2018

Test build #91037 has finished for PR 21406 at commit 567a7ff.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kiszk
Copy link
Member

kiszk commented May 23, 2018

retest this please

Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SparkQA
Copy link

SparkQA commented May 23, 2018

Test build #91060 has finished for PR 21406 at commit 567a7ff.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

thanks, merging to master!

@asfgit asfgit closed this in e108f84 May 24, 2018
@jiangxb1987 jiangxb1987 deleted the handleTaskCompletion branch May 24, 2018 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants